This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Changes to ruleset validation output#3070
Merged
semenko merged 1 commit intoDec 17, 2015
EFForg:masterEFForg/https-everywhere:masterfrom
fuglede:more-explicit-errorsCopy head branch name to clipboard
Merged
Changes to ruleset validation output#3070semenko merged 1 commit intoEFForg:masterEFForg/https-everywhere:masterfrom fuglede:more-explicit-errorsCopy head branch name to clipboard
semenko merged 1 commit into
EFForg:masterEFForg/https-everywhere:masterfrom
fuglede:more-explicit-errorsCopy head branch name to clipboard
Conversation
This achieves a couple of different things: - Previously, when some rulesets contained errors, xmllint would be run twice when running it only once was sufficient. This thus saves a fair amount of time. - Previously, the end of the script would never actually be executed since xmllint would break it. - Echo errors to stderr instead of stdout, - Most importantly: Give some additional output when validation failure is due to one of the two most common ruleset errors, where the existing error output was not particularly helpful.
Contributor
|
Nice work -- thanks! |
semenko
added a commit
that referenced
this pull request
Dec 17, 2015
Changes to ruleset validation output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This achieves a couple of different things: