This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Remove rulesets from coverage whitelist if they pass the coverage test#18066
Closed
pipboy96 wants to merge 2 commits into
EFForg:masterEFForg/https-everywhere:masterfrom
pipboy96:coverage-fixCopy head branch name to clipboard
Closed
Remove rulesets from coverage whitelist if they pass the coverage test#18066pipboy96 wants to merge 2 commits intoEFForg:masterEFForg/https-everywhere:masterfrom pipboy96:coverage-fixCopy head branch name to clipboard
pipboy96 wants to merge 2 commits into
EFForg:masterEFForg/https-everywhere:masterfrom
pipboy96:coverage-fixCopy head branch name to clipboard
Conversation
Member
|
This seems to have changed the ordering of some lines without changing anything else. The previous ordering was sorted with https://github.com/EFForg/https-everywhere/blob/master/utils/ruleset-whitelist-cleanup.sh#L41 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feel free to cherry-pick the first commit and run
ruleset-whitelist-cleanup.shseparately.