This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Remove middle wildcard support in rules.js#17715
Merged
zoracon merged 7 commits intoApr 16, 2019
EFForg:masterEFForg/https-everywhere:masterfrom
cschanaj:remove-middle-wildcard-support-1Copy head branch name to clipboard
Merged
Remove middle wildcard support in rules.js#17715zoracon merged 7 commits intoEFForg:masterEFForg/https-everywhere:masterfrom cschanaj:remove-middle-wildcard-support-1Copy head branch name to clipboard
zoracon merged 7 commits into
EFForg:masterEFForg/https-everywhere:masterfrom
cschanaj:remove-middle-wildcard-support-1Copy head branch name to clipboard
Conversation
24 tasks
Contributor
|
@cschanaj Can you add a test case that checks if middle wildcard causes error and gets ignored as it's supposed to? |
Contributor
|
This may not necessarily work, since some rulesets depend on |
Hainish
suggested changes
Apr 15, 2019
Hainish
left a comment
Member
There was a problem hiding this comment.
Otherwise looks good, thanks!
added 2 commits
April 16, 2019 07:08
zoracon
approved these changes
Apr 16, 2019
zoracon
left a comment
Contributor
There was a problem hiding this comment.
See that the changes asked were made, merging in. Thank you for spending time on this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces #17669 to drop support for middle wildcards in the runtime. hopefully #17711