Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Run node utils/trivialize-rules/trivialize-cookie-rules.js#17574

Closed
cschanaj wants to merge 5 commits into
EFForg:masterEFForg/https-everywhere:masterfrom
cschanaj:run-trivialize-cookie-rulesCopy head branch name to clipboard
Closed

Run node utils/trivialize-rules/trivialize-cookie-rules.js#17574
cschanaj wants to merge 5 commits into
EFForg:masterEFForg/https-everywhere:masterfrom
cschanaj:run-trivialize-cookie-rulesCopy head branch name to clipboard

Conversation

@cschanaj

@cschanaj cschanaj commented Mar 11, 2019

Copy link
Copy Markdown
Collaborator

[DO NOT MERGE]

related #17438

To reproduce da207e4

# travis log from 9fce6df validations test
wget https://api.travis-ci.org/v3/job/504953396/log.txt

# list all xml with failed validations and hash them into a temporary file
cd rules
grep ^ERROR ~/log.txt | grep -Eo '[^/ ]+.xml' | sort -u | xargs sha256sum > /tmp/tmp.txt

# https-everywhere
cd ..
cat /tmp/tmp.txt | sed 's/  /,1,0,/g >> utils/ruleset-whitelist.csv 


<securecookie host=".+" name="^optimizely" />
<securecookie host=".+" name=".+"/>

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is strange...

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently this line is the culprit

if (!securecookie.name === ".+") {

@cschanaj cschanaj closed this Mar 14, 2019
@cschanaj cschanaj deleted the run-trivialize-cookie-rules branch March 14, 2019 22:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.