Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Add patterns to trivialize additional forms of securecookies#16634

Merged
J0WI merged 10 commits into
EFForg:masterEFForg/https-everywhere:masterfrom
cschanaj:trivialize-special-form-securecookies-2Copy head branch name to clipboard
Nov 3, 2018
Merged

Add patterns to trivialize additional forms of securecookies#16634
J0WI merged 10 commits into
EFForg:masterEFForg/https-everywhere:masterfrom
cschanaj:trivialize-special-form-securecookies-2Copy head branch name to clipboard

Conversation

@cschanaj

@cschanaj cschanaj commented Sep 29, 2018 •
edited
Loading

Copy link
Copy Markdown
Collaborator

For d7c053c

wget https://api.travis-ci.org/v3/job/434901070/log.txt
grep ^ERROR ~/log.txt | grep -Eo '[^/]+.xml'  | sort -u | xargs sha256sum >> ~/https-everywhere/utils/ruleset-whitelist.csv
sed -i 's/  /,1,0,0,/g' ~/https-everywhere/utils/ruleset-whitelist.csv

@cschanaj cschanaj mentioned this pull request Sep 29, 2018
Closed
24 tasks
@cschanaj

cschanaj commented Sep 29, 2018

Copy link
Copy Markdown
Collaborator Author

@Hainish cc @J0WI this PR addresses #16540 (comment), AFAIK, all changes are reproducible. Please have a look if you have the time. Thanks.

@cschanaj

cschanaj commented Oct 17, 2018

Copy link
Copy Markdown
Collaborator Author

@Hainish would you be interested to take a look at this PR as well?

@J0WI

J0WI commented Oct 17, 2018

Copy link
Copy Markdown
Contributor

Otherwise I'll just merge it before the next release. The changes in trivialize-cookie-rules.js are trivial.

@J0WI J0WI added this to the Before the Next Release milestone Oct 17, 2018
@Hainish

Hainish commented Oct 17, 2018

Copy link
Copy Markdown
Member

Thanks @J0WI, I'd say you can take the liberty of merging this whenever convenient.

@cschanaj

cschanaj commented Nov 1, 2018 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

@Hainish @zoracon @J0WI it seem that this PR missed the major release... would this get into the next ruleset release?

P.S. fixed the merge conflict in c228bcc, validations now pass as per 59a3181

@J0WI

J0WI commented Nov 1, 2018

Copy link
Copy Markdown
Contributor

Sorry, I wasn't aware of the release date. I'll merge this as soon as Travis is happy.

@J0WI J0WI closed this Nov 1, 2018
@J0WI J0WI reopened this Nov 1, 2018
@cschanaj

cschanaj commented Nov 2, 2018

Copy link
Copy Markdown
Collaborator Author

@J0WI This PR works on securecookie only so I didn't entertain the fetch-test, do you want me to whitelist failing rulesets from fetch-test as well?

@J0WI

J0WI commented Nov 3, 2018

Copy link
Copy Markdown
Contributor

I through it was a regression, but after a closer look nothing relevant changed since I approved this.
Thanks for working on this!

@J0WI J0WI merged commit d9d75f2 into EFForg:master Nov 3, 2018
@cschanaj cschanaj deleted the trivialize-special-form-securecookies-2 branch November 3, 2018 07:30
@cschanaj

cschanaj commented Nov 3, 2018

Copy link
Copy Markdown
Collaborator Author

Thank you!

@Hainish

Hainish commented Nov 5, 2018

Copy link
Copy Markdown
Member

Thanks, this will make it into this weeks ruleset release, usually made on Wednesdays.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@J0WI J0WI J0WI approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

top-10k

Projects

None yet

Milestone

Before the Next Release

Development

Successfully merging this pull request may close these issues.

3 participants

@cschanaj @J0WI @Hainish
Morty Proxy This is a proxified and sanitized view of the page, visit original site.