Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Enhance explode regexp to support \d#16064

Closed
cschanaj wants to merge 1 commit into
EFForg:masterEFForg/https-everywhere:masterfrom
cschanaj:explode-regex-digitsCopy head branch name to clipboard
Closed

Enhance explode regexp to support \d#16064
cschanaj wants to merge 1 commit into
EFForg:masterEFForg/https-everywhere:masterfrom
cschanaj:explode-regex-digitsCopy head branch name to clipboard

Conversation

@cschanaj

@cschanaj cschanaj commented Jul 16, 2018

Copy link
Copy Markdown
Collaborator

This will further trivialize 100+ additional rulesets when merged with #16029

cc @Hainish @RReverser it would be great if you could spare your time to help verify the changes.

@RReverser

Copy link
Copy Markdown
Contributor

I intentionally excluded it, just like limited explicit number of ranges to exclude 0-9 and such. Adding it does trivialise more rules, but explodes target lists beyong reasonable limits.

@cschanaj

Copy link
Copy Markdown
Collaborator Author

@RReverser I didn't notice that it was intentional. I agree that this will explode some target beyond reasonable limit, e.g. sysprovide.xml will explode to 100 target which should be avoided. closing this PR accordingly.

@cschanaj cschanaj closed this Jul 17, 2018
@cschanaj cschanaj deleted the explode-regex-digits branch July 17, 2018 12:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.