Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Re-activate and update NASA.gov.xml#15974

Merged
J0WI merged 22 commits into
EFForg:masterEFForg/https-everywhere:masterfrom
cschanaj:nasa.govCopy head branch name to clipboard
Aug 13, 2018
Merged

Re-activate and update NASA.gov.xml#15974
J0WI merged 22 commits into
EFForg:masterEFForg/https-everywhere:masterfrom
cschanaj:nasa.govCopy head branch name to clipboard

Conversation

@cschanaj

@cschanaj cschanaj commented Jun 30, 2018

Copy link
Copy Markdown
Collaborator

No description provided.

Pasu Chan Chak Shing added 16 commits June 30, 2018 11:05
Re-activate and update NASA.gov.xml
231ad00
Rename nssc.nasa.gov, gone from DNS
003924d
Remove sse.jpl.nasa.gov, gone from DNS
f281295
Remove itsecurity.nasa.gov, gone from DNS
7ecd220
Remove telework.jpl.nasa.gov, gone from DNS
7263d20
Remove metrics.jpl.nasa.gov, gone from DNS
cd5223b
Remove www.data.nasa.gov, gone from DNS
0ce1572
Remove complex rules for search.nasa.gov, obsolete
ecb7089
Remove complex rules for helios.gsfc.nasa.gov, obsolete
b56454d
Remove complex rules for mars.nasa.gov, obsolete
5c3c221
Remove complex rules for www.gsfc.nasa.gov, obsolete
69cc4df
Remove dsm.gsfc.nasa.gov, gone from DNS
afaf63d
Remove complex rules for heasarc.nasa.gov, obsolete
78e9630
Remove complex rules for www.msfc.nasa.gov, obsolete
0ff2744
Remove exclusion for reverb.echo.nasa.gov, all URL redirects to searc…
5da7bed 
…h.earthdata.nasa.gov
Comment out timeout target to pass Travis fetch-test
b9142b4
@cschanaj cschanaj closed this Jun 30, 2018
@cschanaj cschanaj reopened this Jun 30, 2018
@cschanaj cschanaj mentioned this pull request Jun 30, 2018
Closed
88 tasks
@Hainish Hainish added the top-10k label Jul 9, 2018
@J0WI

J0WI commented Aug 12, 2018

Copy link
Copy Markdown
Contributor

Some of the timeouts are not reproducible anymore Would you like to double check them?
LGTM otherwise.

@cschanaj cschanaj closed this Aug 13, 2018
@cschanaj cschanaj reopened this Aug 13, 2018
@J0WI

J0WI commented Aug 13, 2018

Copy link
Copy Markdown
Contributor

Why did you whitelist it from fetch tests? The only error was Could not resolve host: testsite.gsfc.nasa.gov which seems to be legit.

@cschanaj

cschanaj commented Aug 13, 2018

Copy link
Copy Markdown
Collaborator Author

This is because the error was caused by the server side redirect from apd440.gsfc.nasa.gov to testsite.gsfc.nasa.gov, but the domain itself serves HTTPS correctly. I guess this is an internal domain, so it should be fine to remove it. will sybmit a new commit soon.

@cschanaj cschanaj changed the title Re-activate and update NASA.gov.xml Re-activate and update NASA.gov.xml 🚀 Aug 13, 2018
@cschanaj cschanaj changed the title Re-activate and update NASA.gov.xml 🚀 Re-activate and update NASA.gov.xml Aug 13, 2018
@J0WI

J0WI commented Aug 13, 2018

Copy link
Copy Markdown
Contributor

Thanks for clarify!

@J0WI J0WI merged commit 6488fa3 into EFForg:master Aug 13, 2018
@cschanaj cschanaj deleted the nasa.gov branch August 13, 2018 22:26
@wesinator wesinator mentioned this pull request Feb 6, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

ruleset-enhancement top-10k

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cschanaj @J0WI @Hainish
Morty Proxy This is a proxified and sanitized view of the page, visit original site.