This repository was archived by the owner on Nov 6, 2023. It is now read-only.
[STA Travel.com] New ruleset#15882
Merged
Merged
[STA Travel.com] New ruleset#15882
Conversation
This was referenced Jun 23, 2018
Contributor
|
Please have a look at the failing fetch tests in the depending PRs. |
J0WI
reviewed
Jun 30, 2018
| <securecookie host=".+" name=".+" /> | ||
|
|
||
| <!-- http redirect --> | ||
| <exclusion pattern="^http://www\.statravel\.com/(blog|tours)" /> |
Contributor
There was a problem hiding this comment.
Please add a trailing slash for blog
|
|
||
| <!-- http redirect --> | ||
| <exclusion pattern="^http://www\.statravel\.com/(blog|tours)" /> | ||
| <test url="http://www.statravel.com/blogs/" /> |
| <!-- http redirect --> | ||
| <exclusion pattern="^http://www\.statravel\.com/(blog|tours)" /> | ||
| <test url="http://www.statravel.com/blogs/" /> | ||
| <test url="http://www.statravel.com/tours-worldwide.htm" /> |
Contributor
There was a problem hiding this comment.
Are there any other tours* or could you use a more restrictive regex?
Contributor
Author
There was a problem hiding this comment.
/tours.htm is also valid, redirects to /tours-worldwide.htm.
J0WI
approved these changes
Aug 10, 2018
J0WI
left a comment
Contributor
There was a problem hiding this comment.
LGTM so far, but Travis builds are currently broken.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.