Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Create ruleset: Mono project and pronoun.is#15535

Merged
J0WI merged 2 commits into
EFForg:masterEFForg/https-everywhere:masterfrom
FranklinYu:rules/1FranklinYu/https-everywhere:rules/1Copy head branch name to clipboard
Jul 4, 2018
Merged

Create ruleset: Mono project and pronoun.is#15535
J0WI merged 2 commits into
EFForg:masterEFForg/https-everywhere:masterfrom
FranklinYu:rules/1FranklinYu/https-everywhere:rules/1Copy head branch name to clipboard

Conversation

@FranklinYu

@FranklinYu FranklinYu commented May 27, 2018

Copy link
Copy Markdown
Contributor

Two simple rulesets for simple websites.

@FranklinYu

FranklinYu commented May 28, 2018

Copy link
Copy Markdown
Contributor Author

I suppose that the CI breaking issue is not my fault?

ghost
ghost suggested changes May 31, 2018
View reviewed changes
Comment thread src/chrome/content/rules/Mono-project.xml
@@ -0,0 +1,5 @@
<ruleset name="Mono project">
<target host="www.mono-project.com" />

@ghost ghost May 31, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

mono-project.com
download.mono-project.com
origin-download.mono-project.com
news.mono-project.com
jenkins.mono-project.com

@FranklinYu FranklinYu Jun 7, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://mono-project.com and https://news.mono-project.com/ are not available. Please verify.

@ghost ghost Jun 7, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FranklinYu Can verify.

Comment thread src/chrome/content/rules/pronoun.is.xml
@@ -0,0 +1,5 @@
<ruleset name="pronoun.is">
<target host="pronoun.is" />

@ghost ghost May 31, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

www.pronoun.is
hubots.pronoun.is
my.pronoun.is

@FranklinYu FranklinYu Jun 7, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think these domains are available in HTTPS.

@ghost ghost Jun 7, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FranklinYu Then add information about that as a comment.

Comment thread src/chrome/content/rules/Mono-project.xml
@@ -0,0 +1,5 @@
<ruleset name="Mono project">
<target host="www.mono-project.com" />

@ghost ghost May 31, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

<securecookie host=".+" name=".+" />

Comment thread src/chrome/content/rules/pronoun.is.xml
@@ -0,0 +1,5 @@
<ruleset name="pronoun.is">
<target host="pronoun.is" />

@ghost ghost May 31, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

<securecookie host=".+" name=".+" />

@FranklinYu

FranklinYu commented Jun 7, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@YegorIevlev Sorry for late reaction. I didn’t know about the rules for non-working hosts. I updated those two files.

J0WI
J0WI reviewed Jun 16, 2018
View reviewed changes
Comment thread src/chrome/content/rules/pronoun.is.xml
Invalid certificate:
hubots.pronoun.is
my.pronoun.is
www.pronoun.is

@J0WI J0WI Jun 16, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this host has a wildcard DNS. Could you add a comment about this?

Since my and www serve the same content as ^ we can secure them by redirecting to ^.

Comment thread src/chrome/content/rules/Mono-project.xml
@@ -0,0 +1,15 @@
<!--
Invalid certificate:
mono-project.com

@J0WI J0WI Jun 16, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be redirected to www.

@J0WI

J0WI commented Jun 16, 2018

Copy link
Copy Markdown
Contributor

Please push each ruleset in a separate PR for future contributions. 😃

@FranklinYu FranklinYu force-pushed the rules/1 branch 2 times, most recently from 859497e to c894a46 Compare June 30, 2018 05:23
@FranklinYu

FranklinYu commented Jun 30, 2018

Copy link
Copy Markdown
Contributor Author

I don’t think I fully understand why the build fails…

@J0WI

J0WI commented Jun 30, 2018

Copy link
Copy Markdown
Contributor

Please have a look at https://github.com/EFForg/https-everywhere/blob/master/CONTRIBUTING.md#ruleset-style-guide

  • https (or https?) in from should be avoided
  • non-functional hosts and wildcards should be documented with a short comment

@FranklinYu

FranklinYu commented Jun 30, 2018

Copy link
Copy Markdown
Contributor Author

? I thought I was asked to do the redirection?

@J0WI

J0WI commented Jun 30, 2018

Copy link
Copy Markdown
Contributor

Yes, but please only for http. See recent examples.

@FranklinYu

FranklinYu commented Jul 2, 2018

Copy link
Copy Markdown
Contributor Author

Hopefully this would make witch-house/pronoun.is#42 better…

J0WI
J0WI reviewed Jul 3, 2018
View reviewed changes
Comment thread src/chrome/content/rules/pronoun.is.xml
Mismatch:
hubots.pronoun.is
my.pronoun.is
www.pronoun.is

@J0WI J0WI Jul 3, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document that this host has a wildcard DNS record.
LGTM otherwise.

@FranklinYu

FranklinYu commented Jul 4, 2018

Copy link
Copy Markdown
Contributor Author

Got the line from

https-everywhere/src/chrome/content/rules/PDFMerge.com.xml

Lines 1 to 3 in 2033759

<!--
Remark: *.pdfmerge.com have a wildcard DNS Record.
-->

J0WI
J0WI approved these changes Jul 4, 2018
View reviewed changes

@J0WI J0WI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@J0WI J0WI merged commit 737363d into EFForg:master Jul 4, 2018
@FranklinYu FranklinYu deleted the rules/1 branch July 5, 2018 21:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@J0WI J0WI J0WI approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

new-ruleset top-100k

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@FranklinYu @J0WI @Hainish
Morty Proxy This is a proxified and sanitized view of the page, visit original site.