This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Advertising.com:#14130
Merged
J0WI merged 1 commit intoJun 28, 2018
EFForg:masterEFForg/https-everywhere:masterfrom
numismatika:Advertising.comnumismatika/https-everywhere:Advertising.comCopy head branch name to clipboard
Merged
Advertising.com:#14130J0WI merged 1 commit intoEFForg:masterEFForg/https-everywhere:masterfrom numismatika:Advertising.comnumismatika/https-everywhere:Advertising.comCopy head branch name to clipboard
J0WI merged 1 commit into
EFForg:masterEFForg/https-everywhere:masterfrom
numismatika:Advertising.comnumismatika/https-everywhere:Advertising.comCopy head branch name to clipboard
Conversation
numismatika
commented
Dec 30, 2017
Contributor
- add adserver-us subdomain and more
a0a7c90 to
d0e4380
Compare
6f3521c to
a0ba7f7
Compare
5d1c0a4 to
c6ed315
Compare
977c2ff to
f72fa8b
Compare
f72fa8b to
0b9e995
Compare
15ff7b7 to
e3de3a7
Compare
e3de3a7 to
fefdd93
Compare
3af77f9 to
1ec72cb
Compare
3d03b15 to
75371bd
Compare
75371bd to
f055c5c
Compare
J0WI
reviewed
Jun 23, 2018
J0WI
left a comment
Contributor
There was a problem hiding this comment.
Please don't overwrite existing commits on your branch.
| Problematic subdomains: | ||
|
|
||
| - ace-tag * | ||
| - cte.ace.beta (mismatched, CN: servedby.advertising.com) |
Contributor
There was a problem hiding this comment.
This host does still exist, so please keep a comment about it.
Contributor
Author
There was a problem hiding this comment.
cte.ace.beta is part of the -mismatched file so it is already covered there.
289e097 to
5bc919e
Compare
Contributor
|
@numismatika Please don't overwrite existing commits on your branch! It's very time consuming to review the whole rule again. Please just add commits to the branch, we'll squash them anyway during merge. |
Contributor
Author
|
I thought having multiple "test this" "revert the test for this" commits is ugly and in the past the commits weren't always properly squashed so it became a , probably bad, habit to always squash and rebase for each iteration. |
- add adserver-us subdomain and more
5bc919e to
c02613e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.