Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

[unitn.it] Ruleset for University of Tronto and their popular BOINC project#13573

Merged
jeremyn merged 8 commits into
EFForg:masterEFForg/https-everywhere:masterfrom
aladar42:masterCopy head branch name to clipboard
Feb 3, 2018
Merged

[unitn.it] Ruleset for University of Tronto and their popular BOINC project#13573
jeremyn merged 8 commits into
EFForg:masterEFForg/https-everywhere:masterfrom
aladar42:masterCopy head branch name to clipboard

Conversation

@aladar42

Copy link
Copy Markdown
Contributor

Ruleset for http://www.unitn.it/ and their BOINC project TN-Grid at http://gene.disi.unitn.it/test/

@jeremyn

jeremyn commented Dec 23, 2017

Copy link
Copy Markdown
Contributor

@aladar42 Thanks for your pull request. We don't really like to use wildcards. There are a lot of subdomains for unitn.it, so if you don't want to add them all individually, you can use (partial) in the ruleset name and only cover the ones you want. See pull request #9729 for an example of a similar situation.

After you do this, I or another maintainer can take a look at what you have more closely.

@jeremyn jeremyn changed the title Ruleset for University of Tronto and their popular BOINC project [unitn.it] Ruleset for University of Tronto and their popular BOINC project Dec 23, 2017
@aladar42

aladar42 commented Jan 4, 2018

Copy link
Copy Markdown
Contributor Author

I'm goign to take a look at it. Can't guarantee I'll do it all according to standards, though.

@aladar42

aladar42 commented Feb 1, 2018

Copy link
Copy Markdown
Contributor Author

Any updates?

@jeremyn

jeremyn commented Feb 1, 2018

Copy link
Copy Markdown
Contributor

Please rebase your specific changes additions onto master, instead of including what appears to be a merge.

@jeremyn

jeremyn commented Feb 1, 2018

Copy link
Copy Markdown
Contributor

In other words, the "Files changed" tab above should show one file, not the current 883.

Ruleset for University of Tronto and their popular BOINC project

Updated unitn.it as per request
@aladar42

aladar42 commented Feb 2, 2018

Copy link
Copy Markdown
Contributor Author

Sorry, I'm still pretty new to Git. Did I do it correctly now?

Additionally, if it's not too much trouble, what do you recommend as proper pull request in future commits?

@jeremyn

jeremyn commented Feb 2, 2018

Copy link
Copy Markdown
Contributor

The git situation looks okay now, thanks.

  • Please rewrite your pull request like this:
<!--
	Invalid certificate:
		unitn.it
		cimec.unitn.it
		economia.unitn.it

-->
<ruleset name="Unitn.it (partial)">
	<target host="unitn.it" />
	<target host="www.unitn.it" />
	<target host="alumni.unitn.it" />
	<target host="centro3a.unitn.it" />
	<target host="www.centro3a.unitn.it" />
	<target host="cimec.unitn.it" />
	<target host="www.cimec.unitn.it" />
	<target host="gene.disi.unitn.it" />
	<target host="economia.unitn.it" />
	<target host="www.economia.unitn.it" />
	<target host="international.unitn.it" />
	<target host="knowtransfer.unitn.it" />
	<target host="phd-researchfellow.unitn.it" />
	<target host="pressroom.unitn.it" />
	<target host="unitrentosport.unitn.it" />
	<target host="webapps.unitn.it" />
	<target host="webmagazine.unitn.it" />

	<rule from="^http://(cimec\.|economia\.)?unitn\.it/" to="https://www.$1unitn.it/" />
	<rule from="^http:" to="https:" />
</ruleset>

This makes various improvements. Please let me know if you have any questions.

I'm not sure what you are asking in your question about proper pull requests, but you might like to look over our CONTRIBUTING.md.

@jeremyn jeremyn self-assigned this Feb 2, 2018
@aladar42

aladar42 commented Feb 3, 2018

Copy link
Copy Markdown
Contributor Author

Done.

@jeremyn jeremyn merged commit 4d723d7 into EFForg:master Feb 3, 2018
@jeremyn

jeremyn commented Feb 3, 2018

Copy link
Copy Markdown
Contributor

Thanks, merged.

@jeremyn jeremyn removed their assignment Feb 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.