Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Update ruleset-whitelist.csv for rulesets without sufficient coverage#13322

Merged
gloomy-ghost merged 1 commit into
EFForg:masterEFForg/https-everywhere:masterfrom
Bisaloo:fix-travisCopy head branch name to clipboard
Oct 24, 2017
Merged

Update ruleset-whitelist.csv for rulesets without sufficient coverage#13322
gloomy-ghost merged 1 commit into
EFForg:masterEFForg/https-everywhere:masterfrom
Bisaloo:fix-travisCopy head branch name to clipboard

Conversation

@Bisaloo

@Bisaloo Bisaloo commented Oct 24, 2017 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This was caused by commits merged from branches that didn't include the work from @cschanaj in #11998.

@gloomy-ghost, @jeremyn, @J0WI, please be aware that this may be an issue for "old" PR. When in doubt, you should probably ask for a rebase and whitelisting of the faulty ruleset.

@Bisaloo Bisaloo mentioned this pull request Oct 24, 2017
Closed
@gloomy-ghost gloomy-ghost merged commit 0763c2f into EFForg:master Oct 24, 2017
@Bisaloo Bisaloo deleted the fix-travis branch October 24, 2017 08:15
@Hainish

Hainish commented Oct 24, 2017

Copy link
Copy Markdown
Member

@Bisaloo @gloomy-ghost thanks for the quick action here.

@jeremyn

jeremyn commented Oct 24, 2017

Copy link
Copy Markdown
Contributor

A small problem here is privacyintyqcroe.onion.xml being sorted unalphabetically to the bottom of the list. It's not a big deal but it's something to keep in mind for later updates to the whitelist.

@Bisaloo

Bisaloo commented Oct 24, 2017

Copy link
Copy Markdown
Collaborator Author

A small problem here is privacyintyqcroe.onion.xml being sorted unalphabetically to the bottom of the list. It's not a big deal but it's something to keep in mind for later updates to the whitelist.

I know but it's not an issue because the clean up script will sort domains automatically: https://github.com/EFForg/https-everywhere/blob/master/utils/ruleset-whitelist-cleanup.sh#L39

@jeremyn

jeremyn commented Oct 24, 2017

Copy link
Copy Markdown
Contributor

@Bisaloo When does that run?

@Bisaloo

Bisaloo commented Oct 24, 2017

Copy link
Copy Markdown
Collaborator Author

It's part of the release process. See for example https://github.com/EFForg/https-everywhere/pull/12959/files

@jeremyn

jeremyn commented Oct 24, 2017

Copy link
Copy Markdown
Contributor

@Bisaloo Oh okay, that's great. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Bisaloo @Hainish @jeremyn @gloomy-ghost
Morty Proxy This is a proxified and sanitized view of the page, visit original site.