Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Use Map instead of Object for redirectCounter and Fix Memory Leak#12422

Merged
Hainish merged 3 commits into
EFForg:masterEFForg/https-everywhere:masterfrom
cschanaj:fix-mem-leak-1Copy head branch name to clipboard
Sep 8, 2017
Merged

Use Map instead of Object for redirectCounter and Fix Memory Leak#12422
Hainish merged 3 commits into
EFForg:masterEFForg/https-everywhere:masterfrom
cschanaj:fix-mem-leak-1Copy head branch name to clipboard

Conversation

@cschanaj

@cschanaj cschanaj commented Sep 3, 2017

Copy link
Copy Markdown
Collaborator

Step to reproduce the memory leak

  1. From chrome://extensions, open the "Inspect views" for HTTPS Everywhere in a new session.
  2. In the console, type redirectCounter. the console should output something like
Object {} // Empty Object
  1. Visit https://www.nytimes.com/
  2. Repeat Step 2, observe
Object {440: 1, 444, 1}
  1. Repeat Step 3-4, observe redirectCounter keep growing without sign of removing previous items
Object {440: 1, 444: 1, 598: 1, 601: 1, 632: 1, 635: 1}

This affect long lasting browsing sessions.

UPDATE On Mixed Content pages, HTTP request are blocked by MCB from the browser. It is necessary to listen on both HTTP & HTTPS connection to resolve the memory leak (Assuming no "Block all unencrypted requests"). thanks.

P.S. I expected browser to handle redirect loops automatically, however, I am not really sure about the case when an extension rewrite URLs.

@cschanaj

cschanaj commented Sep 6, 2017

Copy link
Copy Markdown
Collaborator Author

@Hainish this fix a memory leak for long lasting browsing sessions, please review and merge this when you have the time. thanks.

@Hainish

Hainish commented Sep 8, 2017

Copy link
Copy Markdown
Member

Thank you!

@Hainish Hainish merged commit c1742b1 into EFForg:master Sep 8, 2017
@cschanaj cschanaj deleted the fix-mem-leak-1 branch September 8, 2017 00:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.