This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Update ruleset-coverage-whitelist-cleanup.sh#11942
Merged
Hainish merged 1 commit intoSep 12, 2017
EFForg:masterEFForg/https-everywhere:masterfrom
cschanaj:fix-cleanup-scriptCopy head branch name to clipboard
Merged
Update ruleset-coverage-whitelist-cleanup.sh#11942Hainish merged 1 commit intoEFForg:masterEFForg/https-everywhere:masterfrom cschanaj:fix-cleanup-scriptCopy head branch name to clipboard
Hainish merged 1 commit into
EFForg:masterEFForg/https-everywhere:masterfrom
cschanaj:fix-cleanup-scriptCopy head branch name to clipboard
Conversation
sorting by the 4th column (ruleset name)
Collaborator
Author
|
@Hainish Can you merge this simple fix? ruleset-whitelist.csv is currently sorted in the wrong order. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Hainish it should be the 4th column if we are sorting according to the filenames. It is sorted by the third column, then by the fourth column currently, leading to strange sorting in #11865 thank!
Also, please run the cleanup script for once after this has been merged.