Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Add ESLint Travis task (WebExtensions)#11178

Closed
ghost wants to merge 31 commits into
webextensionsEFForg/https-everywhere:webextensionsfrom
unknown repositoryCopy head branch name to clipboard
Closed

Add ESLint Travis task (WebExtensions)#11178
ghost wants to merge 31 commits into
webextensionsEFForg/https-everywhere:webextensionsfrom
unknown repositoryCopy head branch name to clipboard

Conversation

@ghost

@ghost ghost commented Jul 16, 2017

Copy link
Copy Markdown

Like #10897 but for WebExtensions! 😎

Hainish and others added 29 commits July 6, 2017 11:11
…d change setversion.py to append to it on every release
extension.getBackgroundPage(), see
https://bugzilla.mozilla.org/show_bug.cgi?id=1329304

Instead, we're using runtime.sendMessage() to pass messages between the
popup and background page.
This reverts commit 886b975.
@ghost

ghost commented Jul 16, 2017

Copy link
Copy Markdown
Author

ping @Hainish

@yfdyh000

Copy link
Copy Markdown
Contributor

@koops76 No "webextensions" in "env"?

@ghost

ghost commented Jul 17, 2017

Copy link
Copy Markdown
Author

@yfdyh000 Fixed. Also fixed for master branch in #11190.

@Hainish

Hainish commented Jul 18, 2017

Copy link
Copy Markdown
Member

It is unnecessary to add this separately to the webextensions branch, because

  1. The syntax for webextensions should not differ from the syntax for the current Chrome extension in any significant way
  2. We already have a .eslint.json file in master. Adding this separately (and with different indentation, to note) will cause merge conflicts down the line. It's better to modify this file in master instead.

@Hainish Hainish closed this Jul 18, 2017
@ghost ghost deleted the webextension-eslint branch July 21, 2017 08:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.