Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Trivialize snapping redirects (^C, experimental)#11024

Merged
J0WI merged 1 commit into
EFForg:masterEFForg/https-everywhere:masterfrom
cschanaj:cschanaj-trr-004Copy head branch name to clipboard
Jul 11, 2017
Merged

Trivialize snapping redirects (^C, experimental)#11024
J0WI merged 1 commit into
EFForg:masterEFForg/https-everywhere:masterfrom
cschanaj:cschanaj-trr-004Copy head branch name to clipboard

Conversation

@cschanaj

@cschanaj cschanaj commented Jul 11, 2017

Copy link
Copy Markdown
Collaborator

No ruleset needed to be excluded.

<securecookie host="www\.cuidadodesalud\.gov"
name=".+" />

<rule from="^(?:http://(?:www\.)?|https://)cuidadodesalud\.gov/"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's weird. There are around 18 rules like this.

@J0WI

J0WI commented Jul 11, 2017

Copy link
Copy Markdown
Contributor

For some reason there are Disabled by https-everywhere-checker because: comments in some rulesets, but this is unrelated to your change. Maybe another cleanup task.

@J0WI J0WI merged commit a7d4969 into EFForg:master Jul 11, 2017
@J0WI

J0WI commented Jul 11, 2017

Copy link
Copy Markdown
Contributor

Sorry, I just discovered that there are some outdated comments in the ruleset, like Cert only matches www or mismatch on ^. I'm not sure if we can change them by script.

@cschanaj cschanaj deleted the cschanaj-trr-004 branch July 12, 2017 03:54
@cschanaj

Copy link
Copy Markdown
Collaborator Author

@J0WI I don't think removing the outdated comment can be done trivially by script. Unlike rewriting direct rewrite as in #10872, removing snapping rewrite actually introduce new rules to the code base . In some rare case (I don't have an example), it can be problematic.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.