This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Update and reactivate ThePirateBay.xml#10679
Closed
Bisaloo wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Duplicate of #10549. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to use this PR to discuss the case of thepiratebay. Currently, the numerous mirrors are secured across 9 rulesets, without any apparent logic behind it.
First of all, we should stop redirecting dead mirrors to working ones, as in
thepiratebay-legacy.xml. It is not this extension job to track the current working mirror. It is very time consuming and it could introduce a security risk (some mirrors may be compromised and we don't want to be responsible for sending users on them). This point was already discussed in #8561.Also, in this case, I am not sure if it would better to group all domain in a single ruleset, that would require frequent but somewhat easy updates or split them in a myriad of smaller rulesets, which would have to be updated less frequently.