Merged
Conversation
Updated the ACadSharp submodule reference to commit f2c81c4c50763df8dfd3167bfc0f7fe94700fae2. Refactored polyline vertex processing in `PdfPen.cs`: - Replaced `polyline.Vertices.Select` with `polyline.GetPoints<XYZ>` to leverage `ArcPrecision` configuration. - Applied transformations more efficiently to improve accuracy and maintainability.
Refactored `PdfPen.cs` to improve text object handling: - Replaced old `MText` processing logic with a new implementation. - Added support for text leading (`TL`) and line-by-line rendering. - Updated default text rendering to use `TextString` (`Tj`). Enhanced `PdfKey.cs` with new PDF operator constants: - Added `BasicTextStart` (`BT`) and `BasicTextEnd` (`ET`). - Introduced `TextTranslation` (`Td`), `TypeFont` (`Tf`), and `TextString` (`Tj`). These changes align the code with PDF specifications and improve modularity.
Replaced hardcoded PDF operators with the `PdfKey.TextString` constant to improve maintainability and consistency. Added a call to `this.appendXY` to explicitly define the text insertion point in the PDF content stream, enhancing text placement accuracy. Updated `MText` handling to use the new constant for appending text lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
General writer update.