Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat: Add lazygit to default install of devcontainer template#332

Open
OCopping wants to merge 2 commits into
mainDiamondLightSource/python-copier-template:mainfrom
add-lazygitDiamondLightSource/python-copier-template:add-lazygitCopy head branch name to clipboard
Open

feat: Add lazygit to default install of devcontainer template#332
OCopping wants to merge 2 commits into
mainDiamondLightSource/python-copier-template:mainfrom
add-lazygitDiamondLightSource/python-copier-template:add-lazygitCopy head branch name to clipboard

Conversation

@OCopping
Copy link
Copy Markdown
Contributor

@OCopping OCopping commented Mar 23, 2026

Can be simplified to an apt install once upgrading to at least a 25.10 base image

@OCopping
Add lazygit to default install of devcontainer template
f5db797 
Can be simplified to an apt install once upgrading to at least a 25.10
base image
@OCopping OCopping requested review from coretl and gilesknap March 23, 2026 14:44
@coretl
Copy link
Copy Markdown
Contributor

coretl commented Mar 23, 2026

Please can you add a test to CI that tests you can at least run lazygit and get the version string out of it, like the uv test

gilesknap
gilesknap reviewed Mar 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gilesknap gilesknap left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we should just wait for 26.04 and do the apt install thing. Plus I think that the install should be moved up in to the ubuntu image. What are your thoughts @coretl?

Also when did we gain conventiional commit validation!! ??

@coretl coretl changed the title Add lazygit to default install of devcontainer template feat: Add lazygit to default install of devcontainer template Mar 25, 2026
@coretl
Copy link
Copy Markdown
Contributor

coretl commented Mar 25, 2026

Plus I think that the install should be moved up in to the ubuntu image. What are your thoughts @coretl?

I can't believe I missed this, serve me right for reviewing on my phone...
Yes, this absolutely should go in the ubuntu-devcontainer repo.

I feel like we should just wait for 26.04 and do the apt install thing.

Maybe? I could be convinced either way. @OCopping can you wait a month for this?

Also when did we gain conventiional commit validation!! ??

@DiamondJoseph added it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gilesknap gilesknap gilesknap left review comments

@coretl coretl Awaiting requested review from coretl

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@OCopping @coretl @gilesknap
Morty Proxy This is a proxified and sanitized view of the page, visit original site.