Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Route nodes minted from non-registration string literals (logger labels, external URLs) — false routes in the API surface #1248

Copy link
Copy link

Description

@mmaripanguec
Issue body actions

What is broken

The indexer creates Route nodes from path-shaped string literals that are not route registrations: labels passed to logging helpers, and even absolute external URLs pulled in from vendored code.

Minimal repro (Go)

// logger.go — NOT a route registration
utils.LogRequests(r, "/login/acme", start)          // minted as Route "/login/acme"
utils.LogRequests(r, "/login/v3/oauth", start)      // minted as Route "/login/v3/oauth"

// vendored ACME client constant — not even this service's URL space
const letsEncryptURL = "https://acme-v02.api.letsencrypt.org/directory"  // minted as Route

Observed via search_graph(label="Route") / SQL over the graph: a gorilla/mux service showed Route nodes for both logger labels and the letsencrypt URLs, plus a Route literally named Login (no leading slash).

Why it matters

Anything consuming the graph as ground truth (as-is generators, architecture docs, agents told "the graph has the real routes") reports an API surface with endpoints that do not exist. In a real 3-repo workspace this produced 2 fake endpoints listed as exposed routes of a BFF.

Expected

A Route node should require anchoring to an actual registration call (HandleFunc / PathPrefix / router-framework equivalent) with file:line evidence — not any string that lexically looks like a path. At minimum: require a leading /, and exclude arguments of known logging/metrics call sites.

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingSomething isn't workingparsing/qualityGraph extraction bugs, false positives, missing edgesGraph extraction bugs, false positives, missing edgespriority/highNeeds near-term maintainer attention; high-impact bug, regression, safety issue, or release blocker.Needs near-term maintainer attention; high-impact bug, regression, safety issue, or release blocker.ux/behaviorDisplay bugs, docs, adoption UXDisplay bugs, docs, adoption UX

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.