Set up react.d.ts for incoming improved TypeScript JSX support - #6721
#6721Closed
RyanCavanaugh wants to merge 1 commit into
DefinitelyTyped:masterDefinitelyTyped/DefinitelyTyped:masterfrom
RyanCavanaugh:improveReactPropsCopy head branch name to clipboard
Closed
Set up react.d.ts for incoming improved TypeScript JSX support#6721RyanCavanaugh wants to merge 1 commit intoDefinitelyTyped:masterDefinitelyTyped/DefinitelyTyped:masterfrom RyanCavanaugh:improveReactPropsCopy head branch name to clipboard
RyanCavanaugh wants to merge 1 commit into
DefinitelyTyped:masterDefinitelyTyped/DefinitelyTyped:masterfrom
RyanCavanaugh:improveReactPropsCopy head branch name to clipboard
Conversation
Member
|
react/react.d.ts to authors(Asana (account can't detected) AssureSign (account can't detected) Microsoft (account can't detected)). could you review this PR? check list
|
Member
Author
|
Working on test failures |
Contributor
|
It might be easier to do this after we've merged #6205. |
Member
Author
|
Starting fresh based on that commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets up react.d.ts to be in good shape for the changes in microsoft/TypeScript#5478
Specifically, once this and microsoft/TypeScript#5596 are in:
React.Props<T>in component definitionsreforkeyon your component classrefwill always have the correct typerefon a SFC-based elementrefcallbacks for built-in elements (e.g.div) will have fully-correct contextual types (e.g.xisHTMLDivElementin<div ref={ x => ... } />