core-js: Fix tests that fail due to callback covariance#17246
Merged
sandersn merged 1 commit intoJun 20, 2017
masterDefinitelyTyped/DefinitelyTyped:masterfrom
core-js-covarianceDefinitelyTyped/DefinitelyTyped:core-js-covarianceCopy head branch name to clipboard
Merged
core-js: Fix tests that fail due to callback covariance#17246sandersn merged 1 commit intomasterDefinitelyTyped/DefinitelyTyped:masterfrom core-js-covarianceDefinitelyTyped/DefinitelyTyped:core-js-covarianceCopy head branch name to clipboard
sandersn merged 1 commit into
masterDefinitelyTyped/DefinitelyTyped:masterfrom
core-js-covarianceDefinitelyTyped/DefinitelyTyped:core-js-covarianceCopy head branch name to clipboard
Conversation
sandersn
approved these changes
Jun 16, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests are now failing thanks to microsoft/TypeScript#15104. They all look like legitimate failures, so I changed the tests to be correct.