You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
convert_legacy_peak_fit_params() and convert_legacy_peak_creation_params() are available from Sigima but referenced nowhere in DataLab-Web. Opening an HDF5 workspace saved before the height-based migration (metadata keyed by amp) makes Evaluate fit raise a bare LegacyPeakParameterizationError, with no explanation and no way forward.
Refusing to silently reinterpret an area as a height is scientifically correct. Surfacing a raw exception is not.
Proposed resolution
Catch the error at the runtime boundary and either offer an explicit "convert legacy parameters" action or display a message stating what changed and which release introduced it. Add a CHANGELOG entry: nothing currently warns users that pre-0.6.4 workspaces need attention.
Summary
convert_legacy_peak_fit_params()andconvert_legacy_peak_creation_params()are available from Sigima but referenced nowhere in DataLab-Web. Opening an HDF5 workspace saved before the height-based migration (metadata keyed byamp) makes Evaluate fit raise a bareLegacyPeakParameterizationError, with no explanation and no way forward.Refusing to silently reinterpret an area as a height is scientifically correct. Surfacing a raw exception is not.
Proposed resolution
Catch the error at the runtime boundary and either offer an explicit "convert legacy parameters" action or display a message stating what changed and which release introduced it. Add a CHANGELOG entry: nothing currently warns users that pre-0.6.4 workspaces need attention.
Not addressed on the
fix/fitting-auditbranch.