refactor: extract applyDictWithRepStitch to reduce allocation pressure in decodeDictV1 rep-level path#193
Open
darthcoder wants to merge 2 commits into
Open
refactor: extract applyDictWithRepStitch to reduce allocation pressure in decodeDictV1 rep-level path#193darthcoder wants to merge 2 commits into
darthcoder wants to merge 2 commits into
Conversation
…epStitch - Add missing `Int` parameter (maxDef) to the type signature - Use `map (ds V.!) (VU.toList idxs)` for DInt96 and DText, since UTCTime and Text have no VU.Unbox instance and cannot be produced by VU.map
Author
|
this is in regards my gsoc application for summer of haskell. hope this is not a waste of the mentors time. While i wanted to learn sufficient amount of haskell to be productive on my own I had to rely a bit on claude in the clutch. If the AI policy is no ai usage then I am willing to only checkin handwritten code from the next time onwards but since the complete test suite is passing and the fix is what i intended it to be even if i am not proficient enough in the syntax i hope it is accepted. |
Author
|
hi just wanted to no why this has not yet been merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
applyDictWithRepStitchfrom the rep-level branch ofdecodeDictV1, replacing a 27-line inlinedo/caseblock with a single callVU.map (ds V.!)(stays in unboxed vector space) instead ofmap (ds V.!) . VU.toListfor allVU.Unboxtypes (Bool,Int32,Int64,Float,Double), avoiding materialisation of an intermediate listUTCTime(DInt96) andText(DText) have noVU.Unboxinstance and correctly fall back tomap (ds V.!) (VU.toList idxs)Closes / relates to #151.
Test plan
cabal test— all 453 HUnit cases pass, all 23 QuickCheck suites pass (100 tests each)src/DataFrame/IO/Parquet/Dictionary.hs🤖 Generated with Claude Code