Merged
fix: resolve persistent ASAN CI failures#491
Conversation
…ation Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Filter LD_PRELOAD from gtest env: binaries compiled with -fsanitize=address already have libasan.so as a NEEDED dependency; preloading it again caused "incompatible ASan runtimes" abort before any test ran - Lower CollapsingSleepTest WEIGHT threshold 900→700 to accommodate ASAN overhead (~10% sampling reduction observed in CI) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
CI Test ResultsRun: #24654248403 | Commit:
Status Overview
Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled Summary: Total: 54 | Passed: 54 | Failed: 0 Updated: 2026-04-20 08:02:07 UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Fixes two persistent failures in the ASAN CI run.
GTest ASAN tests crash immediately — all
gtestAsan_*tasks were aborting with==PID==Your application is linked against incompatible ASan runtimes.before running a single test case.LD_PRELOAD=libasan.sowas being applied to gtest executables that are already compiled with-fsanitize=addressand havelibasan.soas a NEEDED dependency. The dynamic linker initialized the ASAN runtime from that dependency;LD_PRELOADthen attempted a second initialization, causing the abort. SinceisIgnoreExitValue = true(failFast defaults to false), all crashes were silently ignored — every gtest ASAN test was effectively not running.CollapsingSleepTest.testSleep()fails on weight threshold — the test parks for 1 second atwall=~1msand assertssum(WEIGHT) > 900. Under ASAN, profiler signal delivery is slower, resulting in ~898ms of captured wall time — just below the 900ms boundary. Lowering the threshold to 700 preserves the test's intent (verify collapsing sleep accumulates significant wall time) while giving 30% headroom for sanitizer overhead.Motivation:
ASAN CI runs have been persistently red. The gtest issue means ASAN unit tests are silently not executing at all, defeating the purpose of the ASAN build.
Additional Notes:
LD_PRELOADis still correctly applied to Java tests (ddprof-test:testAsan) where the JVM itself is not ASAN-instrumented butlibjavaProfiler.sois — that path is unaffected by this change.How to test the change?:
Run the ASAN CI job:
./gradlew :ddprof-lib:gtestAsan -Pconfiguration=asanlocally with a clang that has libasan. The gtest binaries should no longer abort on startup. TheCollapsingSleepTestshould pass consistently.For Datadog employees: