Reduce use of activeScope() in instrumentation by mcculls · Pull Request #8470 · DataDog/dd-trace-java

mcculls · Feb 28, 2025

Motivation

Most of the time we're only interested in whether there's an active span - we don't need the actual closeable handle.

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: APMAPI-956

pr-commenter · Feb 28, 2025

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/reduce-active-scope-usage
git_commit_date	1740758111	1740758390
git_commit_sha	`19d8832`	`1486bda`
release_version	1.47.0-SNAPSHOT~19d8832a9d	1.47.0-SNAPSHOT~1486bda56a

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1740762407	1740762407
ci_job_id	828017059	828017059
ci_pipeline_id	57358511	57358511
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-v1phgxi-project-304-concurrent-0-0nnqkedd 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-v1phgxi-project-304-concurrent-0-0nnqkedd 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 6 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~1486bda56a, baseline=1.47.0-SNAPSHOT~19d8832a9d

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1042484
Total [baseline] (8.659 s) : 0, 8658669
Agent [candidate] (1.041 s) : 0, 1041064
Total [candidate] (8.655 s) : 0, 8654916
section iast
Agent [baseline] (1.168 s) : 0, 1168423
Total [baseline] (9.25 s) : 0, 9249848
Agent [candidate] (1.168 s) : 0, 1168163
Total [candidate] (9.232 s) : 0, 9231621
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.173 s) : 0, 1172860
Total [baseline] (9.216 s) : 0, 9216248
Agent [candidate] (1.179 s) : 0, 1179266
Total [candidate] (9.214 s) : 0, 9214147
section iast_TELEMETRY_OFF
Agent [baseline] (1.167 s) : 0, 1167110
Total [baseline] (9.251 s) : 0, 9251437
Agent [candidate] (1.164 s) : 0, 1163738
Total [candidate] (9.223 s) : 0, 9223394

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.042 s	-
Agent	iast	1.168 s	125.939 ms (12.1%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.173 s	130.376 ms (12.5%)
Agent	iast_TELEMETRY_OFF	1.167 s	124.626 ms (12.0%)
Total	tracing	8.659 s	-
Total	iast	9.25 s	591.179 ms (6.8%)
Total	iast_HARDCODED_SECRET_DISABLED	9.216 s	557.579 ms (6.4%)
Total	iast_TELEMETRY_OFF	9.251 s	592.768 ms (6.8%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.041 s	-
Agent	iast	1.168 s	127.099 ms (12.2%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.179 s	138.201 ms (13.3%)
Agent	iast_TELEMETRY_OFF	1.164 s	122.673 ms (11.8%)
Total	tracing	8.655 s	-
Total	iast	9.232 s	576.705 ms (6.7%)
Total	iast_HARDCODED_SECRET_DISABLED	9.214 s	559.231 ms (6.5%)
Total	iast_TELEMETRY_OFF	9.223 s	568.478 ms (6.6%)

gantt
    title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~1486bda56a, baseline=1.47.0-SNAPSHOT~19d8832a9d

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (720.167 ms) : 0, 720167
BytebuddyAgent [candidate] (720.296 ms) : 0, 720296
GlobalTracer [baseline] (239.583 ms) : 0, 239583
GlobalTracer [candidate] (238.914 ms) : 0, 238914
AppSec [baseline] (55.649 ms) : 0, 55649
AppSec [candidate] (55.473 ms) : 0, 55473
Remote Config [baseline] (691.883 µs) : 0, 692
Remote Config [candidate] (701.357 µs) : 0, 701
Telemetry [baseline] (11.356 ms) : 0, 11356
Telemetry [candidate] (10.707 ms) : 0, 10707
section iast
BytebuddyAgent [baseline] (835.323 ms) : 0, 835323
BytebuddyAgent [candidate] (834.565 ms) : 0, 834565
GlobalTracer [baseline] (229.316 ms) : 0, 229316
GlobalTracer [candidate] (229.134 ms) : 0, 229134
IAST [baseline] (22.643 ms) : 0, 22643
IAST [candidate] (22.837 ms) : 0, 22837
AppSec [baseline] (56.813 ms) : 0, 56813
AppSec [candidate] (57.288 ms) : 0, 57288
Remote Config [baseline] (691.987 µs) : 0, 692
Remote Config [candidate] (622.468 µs) : 0, 622
Telemetry [baseline] (8.69 ms) : 0, 8690
Telemetry [candidate] (8.716 ms) : 0, 8716
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (837.455 ms) : 0, 837455
BytebuddyAgent [candidate] (842.636 ms) : 0, 842636
GlobalTracer [baseline] (230.328 ms) : 0, 230328
GlobalTracer [candidate] (231.161 ms) : 0, 231161
IAST [baseline] (23.05 ms) : 0, 23050
IAST [candidate] (23.054 ms) : 0, 23054
AppSec [baseline] (57.535 ms) : 0, 57535
AppSec [candidate] (57.861 ms) : 0, 57861
Remote Config [baseline] (610.64 µs) : 0, 611
Remote Config [candidate] (623.343 µs) : 0, 623
Telemetry [baseline] (8.785 ms) : 0, 8785
Telemetry [candidate] (8.827 ms) : 0, 8827
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (833.674 ms) : 0, 833674
BytebuddyAgent [candidate] (831.143 ms) : 0, 831143
GlobalTracer [baseline] (229.495 ms) : 0, 229495
GlobalTracer [candidate] (228.968 ms) : 0, 228968
IAST [baseline] (27.157 ms) : 0, 27157
IAST [candidate] (23.791 ms) : 0, 23791
AppSec [baseline] (52.563 ms) : 0, 52563
AppSec [candidate] (54.883 ms) : 0, 54883
Remote Config [baseline] (622.437 µs) : 0, 622
Remote Config [candidate] (621.72 µs) : 0, 622
Telemetry [baseline] (8.68 ms) : 0, 8680
Telemetry [candidate] (8.634 ms) : 0, 8634

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~1486bda56a, baseline=1.47.0-SNAPSHOT~19d8832a9d

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.037 s) : 0, 1037106
Total [baseline] (10.348 s) : 0, 10348470
Agent [candidate] (1.038 s) : 0, 1038346
Total [candidate] (10.43 s) : 0, 10429864
section appsec
Agent [baseline] (1.186 s) : 0, 1185505
Total [baseline] (10.742 s) : 0, 10741697
Agent [candidate] (1.181 s) : 0, 1181046
Total [candidate] (10.772 s) : 0, 10772309
section iast
Agent [baseline] (1.173 s) : 0, 1172689
Total [baseline] (11.029 s) : 0, 11028869
Agent [candidate] (1.169 s) : 0, 1169131
Total [candidate] (10.971 s) : 0, 10970804
section profiling
Agent [baseline] (1.263 s) : 0, 1262581
Total [baseline] (10.796 s) : 0, 10795617
Agent [candidate] (1.274 s) : 0, 1274028
Total [candidate] (10.943 s) : 0, 10942779

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.037 s	-
Agent	appsec	1.186 s	148.4 ms (14.3%)
Agent	iast	1.173 s	135.583 ms (13.1%)
Agent	profiling	1.263 s	225.475 ms (21.7%)
Total	tracing	10.348 s	-
Total	appsec	10.742 s	393.227 ms (3.8%)
Total	iast	11.029 s	680.399 ms (6.6%)
Total	profiling	10.796 s	447.147 ms (4.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.038 s	-
Agent	appsec	1.181 s	142.699 ms (13.7%)
Agent	iast	1.169 s	130.785 ms (12.6%)
Agent	profiling	1.274 s	235.682 ms (22.7%)
Total	tracing	10.43 s	-
Total	appsec	10.772 s	342.445 ms (3.3%)
Total	iast	10.971 s	540.94 ms (5.2%)
Total	profiling	10.943 s	512.915 ms (4.9%)

gantt
    title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~1486bda56a, baseline=1.47.0-SNAPSHOT~19d8832a9d

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (715.609 ms) : 0, 715609
BytebuddyAgent [candidate] (715.676 ms) : 0, 715676
GlobalTracer [baseline] (238.111 ms) : 0, 238111
GlobalTracer [candidate] (238.462 ms) : 0, 238462
AppSec [baseline] (55.481 ms) : 0, 55481
AppSec [candidate] (55.446 ms) : 0, 55446
Remote Config [baseline] (693.54 µs) : 0, 694
Remote Config [candidate] (696.19 µs) : 0, 696
Telemetry [baseline] (12.339 ms) : 0, 12339
Telemetry [candidate] (13.104 ms) : 0, 13104
section appsec
BytebuddyAgent [baseline] (737.172 ms) : 0, 737172
BytebuddyAgent [candidate] (733.185 ms) : 0, 733185
GlobalTracer [baseline] (236.052 ms) : 0, 236052
GlobalTracer [candidate] (235.134 ms) : 0, 235134
IAST [baseline] (21.709 ms) : 0, 21709
IAST [candidate] (21.68 ms) : 0, 21680
AppSec [baseline] (177.431 ms) : 0, 177431
AppSec [candidate] (177.887 ms) : 0, 177887
Remote Config [baseline] (666.057 µs) : 0, 666
Remote Config [candidate] (668.728 µs) : 0, 669
Telemetry [baseline] (8.347 ms) : 0, 8347
Telemetry [candidate] (8.374 ms) : 0, 8374
section iast
BytebuddyAgent [baseline] (836.81 ms) : 0, 836810
BytebuddyAgent [candidate] (835.934 ms) : 0, 835934
GlobalTracer [baseline] (229.896 ms) : 0, 229896
GlobalTracer [candidate] (229.099 ms) : 0, 229099
IAST [baseline] (23.152 ms) : 0, 23152
IAST [candidate] (23.489 ms) : 0, 23489
AppSec [baseline] (58.296 ms) : 0, 58296
AppSec [candidate] (56.375 ms) : 0, 56375
Remote Config [baseline] (614.062 µs) : 0, 614
Remote Config [candidate] (602.448 µs) : 0, 602
Telemetry [baseline] (8.887 ms) : 0, 8887
Telemetry [candidate] (8.67 ms) : 0, 8670
section profiling
BytebuddyAgent [baseline] (709.776 ms) : 0, 709776
BytebuddyAgent [candidate] (717.436 ms) : 0, 717436
GlobalTracer [baseline] (350.105 ms) : 0, 350105
GlobalTracer [candidate] (352.5 ms) : 0, 352500
AppSec [baseline] (55.831 ms) : 0, 55831
AppSec [candidate] (55.29 ms) : 0, 55290
Remote Config [baseline] (678.434 µs) : 0, 678
Remote Config [candidate] (671.719 µs) : 0, 672
Telemetry [baseline] (9.007 ms) : 0, 9007
Telemetry [candidate] (9.113 ms) : 0, 9113
ProfilingAgent [baseline] (96.699 ms) : 0, 96699
ProfilingAgent [candidate] (98.141 ms) : 0, 98141
Profiling [baseline] (96.723 ms) : 0, 96723
Profiling [candidate] (98.165 ms) : 0, 98165

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-02-28T16:37:03	2025-02-28T16:44:45
git_branch	master	mcculls/reduce-active-scope-usage
git_commit_date	1740758111	1740758390
git_commit_sha	`19d8832`	`1486bda`
release_version	1.47.0-SNAPSHOT~19d8832a9d	1.47.0-SNAPSHOT~1486bda56a
start_time	2025-02-28T16:36:49	2025-02-28T16:44:31

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1740761481	1740761481
ci_job_id	828017060	828017060
ci_pipeline_id	57358511	57358511
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-cxumtg-z-project-304-concurrent-0-fm1apejf 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-cxumtg-z-project-304-concurrent-0-fm1apejf 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~1486bda56a, baseline=1.47.0-SNAPSHOT~19d8832a9d
    dateFormat X
    axisFormat %s
section baseline
no_agent (375.863 µs) : 356, 396
.   : milestone, 376,
iast (506.807 µs) : 485, 529
.   : milestone, 507,
iast_FULL (720.305 µs) : 698, 742
.   : milestone, 720,
iast_GLOBAL (560.803 µs) : 538, 584
.   : milestone, 561,
iast_HARDCODED_SECRET_DISABLED (507.595 µs) : 485, 530
.   : milestone, 508,
iast_INACTIVE (461.189 µs) : 439, 483
.   : milestone, 461,
iast_TELEMETRY_OFF (494.716 µs) : 472, 518
.   : milestone, 495,
tracing (457.073 µs) : 436, 478
.   : milestone, 457,
section candidate
no_agent (370.141 µs) : 350, 390
.   : milestone, 370,
iast (504.376 µs) : 482, 527
.   : milestone, 504,
iast_FULL (721.779 µs) : 700, 744
.   : milestone, 722,
iast_GLOBAL (551.429 µs) : 530, 573
.   : milestone, 551,
iast_HARDCODED_SECRET_DISABLED (509.709 µs) : 487, 532
.   : milestone, 510,
iast_INACTIVE (456.71 µs) : 435, 478
.   : milestone, 457,
iast_TELEMETRY_OFF (497.837 µs) : 474, 521
.   : milestone, 498,
tracing (448.508 µs) : 428, 469
.   : milestone, 449,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	375.863 µs [355.836 µs, 395.889 µs]	-
iast	506.807 µs [485.012 µs, 528.602 µs]	130.945 µs (34.8%)
iast_FULL	720.305 µs [698.373 µs, 742.237 µs]	344.443 µs (91.6%)
iast_GLOBAL	560.803 µs [537.648 µs, 583.959 µs]	184.94 µs (49.2%)
iast_HARDCODED_SECRET_DISABLED	507.595 µs [485.212 µs, 529.979 µs]	131.733 µs (35.0%)
iast_INACTIVE	461.189 µs [439.008 µs, 483.369 µs]	85.326 µs (22.7%)
iast_TELEMETRY_OFF	494.716 µs [471.9 µs, 517.533 µs]	118.853 µs (31.6%)
tracing	457.073 µs [435.985 µs, 478.161 µs]	81.211 µs (21.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	370.141 µs [350.28 µs, 390.002 µs]	-
iast	504.376 µs [481.748 µs, 527.004 µs]	134.235 µs (36.3%)
iast_FULL	721.779 µs [699.943 µs, 743.615 µs]	351.638 µs (95.0%)
iast_GLOBAL	551.429 µs [529.668 µs, 573.191 µs]	181.288 µs (49.0%)
iast_HARDCODED_SECRET_DISABLED	509.709 µs [487.026 µs, 532.391 µs]	139.567 µs (37.7%)
iast_INACTIVE	456.71 µs [435.039 µs, 478.381 µs]	86.569 µs (23.4%)
iast_TELEMETRY_OFF	497.837 µs [474.202 µs, 521.471 µs]	127.695 µs (34.5%)
tracing	448.508 µs [427.786 µs, 469.229 µs]	78.367 µs (21.2%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~1486bda56a, baseline=1.47.0-SNAPSHOT~19d8832a9d
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.349 ms) : 1329, 1369
.   : milestone, 1349,
appsec (1.717 ms) : 1694, 1741
.   : milestone, 1717,
appsec_no_iast (1.706 ms) : 1681, 1730
.   : milestone, 1706,
code_origins (1.7 ms) : 1668, 1733
.   : milestone, 1700,
iast (1.51 ms) : 1486, 1534
.   : milestone, 1510,
profiling (1.516 ms) : 1493, 1539
.   : milestone, 1516,
tracing (1.498 ms) : 1474, 1523
.   : milestone, 1498,
section candidate
no_agent (1.336 ms) : 1317, 1355
.   : milestone, 1336,
appsec (1.72 ms) : 1697, 1744
.   : milestone, 1720,
appsec_no_iast (1.72 ms) : 1695, 1745
.   : milestone, 1720,
code_origins (1.679 ms) : 1646, 1712
.   : milestone, 1679,
iast (1.498 ms) : 1474, 1522
.   : milestone, 1498,
profiling (1.504 ms) : 1482, 1527
.   : milestone, 1504,
tracing (1.49 ms) : 1465, 1515
.   : milestone, 1490,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.349 ms [1.329 ms, 1.369 ms]	-
appsec	1.717 ms [1.694 ms, 1.741 ms]	368.224 µs (27.3%)
appsec_no_iast	1.706 ms [1.681 ms, 1.73 ms]	356.282 µs (26.4%)
code_origins	1.7 ms [1.668 ms, 1.733 ms]	351.222 µs (26.0%)
iast	1.51 ms [1.486 ms, 1.534 ms]	160.7 µs (11.9%)
profiling	1.516 ms [1.493 ms, 1.539 ms]	167.117 µs (12.4%)
tracing	1.498 ms [1.474 ms, 1.523 ms]	149.122 µs (11.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.336 ms [1.317 ms, 1.355 ms]	-
appsec	1.72 ms [1.697 ms, 1.744 ms]	384.146 µs (28.7%)
appsec_no_iast	1.72 ms [1.695 ms, 1.745 ms]	383.409 µs (28.7%)
code_origins	1.679 ms [1.646 ms, 1.712 ms]	342.642 µs (25.6%)
iast	1.498 ms [1.474 ms, 1.522 ms]	162.131 µs (12.1%)
profiling	1.504 ms [1.482 ms, 1.527 ms]	167.989 µs (12.6%)
tracing	1.49 ms [1.465 ms, 1.515 ms]	153.504 µs (11.5%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/reduce-active-scope-usage
git_commit_date	1740758111	1740758390
git_commit_sha	`19d8832`	`1486bda`
release_version	1.47.0-SNAPSHOT~19d8832a9d	1.47.0-SNAPSHOT~1486bda56a

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1740761890	1740761890
ci_job_id	828017061	828017061
ci_pipeline_id	57358511	57358511
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-v1phgxi-project-304-concurrent-1-xvhtvlr0 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-v1phgxi-project-304-concurrent-1-xvhtvlr0 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~1486bda56a, baseline=1.47.0-SNAPSHOT~19d8832a9d
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.234 s) : 15234000, 15234000
.   : milestone, 15234000,
appsec (14.83 s) : 14830000, 14830000
.   : milestone, 14830000,
iast (18.539 s) : 18539000, 18539000
.   : milestone, 18539000,
iast_GLOBAL (18.074 s) : 18074000, 18074000
.   : milestone, 18074000,
profiling (14.996 s) : 14996000, 14996000
.   : milestone, 14996000,
tracing (14.702 s) : 14702000, 14702000
.   : milestone, 14702000,
section candidate
no_agent (15.515 s) : 15515000, 15515000
.   : milestone, 15515000,
appsec (15.043 s) : 15043000, 15043000
.   : milestone, 15043000,
iast (19.062 s) : 19062000, 19062000
.   : milestone, 19062000,
iast_GLOBAL (17.763 s) : 17763000, 17763000
.   : milestone, 17763000,
profiling (15.094 s) : 15094000, 15094000
.   : milestone, 15094000,
tracing (15.231 s) : 15231000, 15231000
.   : milestone, 15231000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.234 s [15.234 s, 15.234 s]	-
appsec	14.83 s [14.83 s, 14.83 s]	-404.0 ms (-2.7%)
iast	18.539 s [18.539 s, 18.539 s]	3.305 s (21.7%)
iast_GLOBAL	18.074 s [18.074 s, 18.074 s]	2.84 s (18.6%)
profiling	14.996 s [14.996 s, 14.996 s]	-238.0 ms (-1.6%)
tracing	14.702 s [14.702 s, 14.702 s]	-532.0 ms (-3.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.515 s [15.515 s, 15.515 s]	-
appsec	15.043 s [15.043 s, 15.043 s]	-472.0 ms (-3.0%)
iast	19.062 s [19.062 s, 19.062 s]	3.547 s (22.9%)
iast_GLOBAL	17.763 s [17.763 s, 17.763 s]	2.248 s (14.5%)
profiling	15.094 s [15.094 s, 15.094 s]	-421.0 ms (-2.7%)
tracing	15.231 s [15.231 s, 15.231 s]	-284.0 ms (-1.8%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~1486bda56a, baseline=1.47.0-SNAPSHOT~19d8832a9d
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.47 ms) : 1459, 1482
.   : milestone, 1470,
appsec (2.349 ms) : 2305, 2392
.   : milestone, 2349,
iast (2.116 ms) : 2061, 2172
.   : milestone, 2116,
iast_GLOBAL (2.164 ms) : 2108, 2220
.   : milestone, 2164,
profiling (1.987 ms) : 1942, 2033
.   : milestone, 1987,
tracing (1.957 ms) : 1914, 2000
.   : milestone, 1957,
section candidate
no_agent (1.471 ms) : 1459, 1482
.   : milestone, 1471,
appsec (2.338 ms) : 2295, 2382
.   : milestone, 2338,
iast (2.109 ms) : 2054, 2164
.   : milestone, 2109,
iast_GLOBAL (2.153 ms) : 2097, 2209
.   : milestone, 2153,
profiling (2.004 ms) : 1959, 2049
.   : milestone, 2004,
tracing (1.954 ms) : 1912, 1997
.   : milestone, 1954,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.47 ms [1.459 ms, 1.482 ms]	-
appsec	2.349 ms [2.305 ms, 2.392 ms]	878.494 µs (59.8%)
iast	2.116 ms [2.061 ms, 2.172 ms]	646.07 µs (43.9%)
iast_GLOBAL	2.164 ms [2.108 ms, 2.22 ms]	693.988 µs (47.2%)
profiling	1.987 ms [1.942 ms, 2.033 ms]	517.359 µs (35.2%)
tracing	1.957 ms [1.914 ms, 2.0 ms]	486.923 µs (33.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.471 ms [1.459 ms, 1.482 ms]	-
appsec	2.338 ms [2.295 ms, 2.382 ms]	867.588 µs (59.0%)
iast	2.109 ms [2.054 ms, 2.164 ms]	638.387 µs (43.4%)
iast_GLOBAL	2.153 ms [2.097 ms, 2.209 ms]	682.175 µs (46.4%)
profiling	2.004 ms [1.959 ms, 2.049 ms]	533.18 µs (36.3%)
tracing	1.954 ms [1.912 ms, 1.997 ms]	483.663 µs (32.9%)

nikita-tkachenko-datadog

LGTM for CI Vis changes

PerfectSlayer

A minor comment but looks good 👍

mcculls added comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring labels Feb 28, 2025

mcculls marked this pull request as ready for review February 28, 2025 12:22

mcculls requested review from a team as code owners February 28, 2025 12:22

mcculls requested review from PerfectSlayer and nikita-tkachenko-datadog February 28, 2025 12:22

nikita-tkachenko-datadog approved these changes Feb 28, 2025

View reviewed changes

PerfectSlayer approved these changes Feb 28, 2025

View reviewed changes

Comment thread ...c/main/java/datadog/trace/instrumentation/couchbase/client/CouchbaseCoreInstrumentation.java Outdated

mcculls force-pushed the mcculls/reduce-active-scope-usage branch 3 times, most recently from 5cd9822 to 76e8095 Compare February 28, 2025 15:57

Reduce use of activeScope() in instrumentation

1486bda

mcculls force-pushed the mcculls/reduce-active-scope-usage branch from 76e8095 to 1486bda Compare February 28, 2025 15:59

mcculls merged commit ba51027 into master Feb 28, 2025

mcculls deleted the mcculls/reduce-active-scope-usage branch February 28, 2025 17:17

github-actions Bot added this to the 1.47.0 milestone Feb 28, 2025

mcculls restored the mcculls/reduce-active-scope-usage branch March 1, 2025 00:35

mcculls deleted the mcculls/reduce-active-scope-usage branch March 1, 2025 00:38

mcculls mentioned this pull request Mar 3, 2025

Prefer using activeSpan() over activeScope() #8492

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Reduce use of activeScope() in instrumentation#8470

Reduce use of activeScope() in instrumentation#8470
mcculls merged 1 commit into
masterDataDog/dd-trace-java:masterfrom
mcculls/reduce-active-scope-usageDataDog/dd-trace-java:mcculls/reduce-active-scope-usageCopy head branch name to clipboard

mcculls commented Feb 28, 2025 •

edited by atlassian Bot

Loading

Uh oh!

pr-commenter Bot commented Feb 28, 2025 •

edited

Loading

Uh oh!

nikita-tkachenko-datadog left a comment

Uh oh!

PerfectSlayer left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Search code, repositories, users, issues, pull requests...

Uh oh!

Conversation

mcculls commented Feb 28, 2025 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Contributor Checklist

Uh oh!

pr-commenter Bot commented Feb 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

nikita-tkachenko-datadog left a comment

Choose a reason for hiding this comment

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mcculls commented Feb 28, 2025 •

edited by atlassian Bot

Loading

pr-commenter Bot commented Feb 28, 2025 •

edited

Loading