Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Implement check metadata payloads - #2554

#2554
Closed
ofek wants to merge 1 commit into
masterDataDog/datadog-agent:masterfrom
ofek/metadataDataDog/datadog-agent:ofek/metadataCopy head branch name to clipboard
Closed

Implement check metadata payloads#2554
ofek wants to merge 1 commit into
masterDataDog/datadog-agent:masterfrom
ofek/metadataDataDog/datadog-agent:ofek/metadataCopy head branch name to clipboard

Conversation

@ofek

@ofek ofek commented Nov 6, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Implements a way for checks to send their own metadata. The backend will learn to work with this in upcoming PRs to respective repos.

Motivation

So we can track things like versions of applications monitored (MySQL, Redis, ...), configuration options used, etc.

@ofek ofek added [deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead.. [deprecated] team/integrations labels Nov 6, 2018
@ofek ofek added this to the 6.8.0 milestone Nov 6, 2018
@ofek
ofek requested a review from a team as a code owner November 6, 2018 03:02
@codecov-io

codecov-io commented Nov 6, 2018 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2554 into master will decrease coverage by 0.51%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2554      +/-   ##
==========================================
- Coverage   57.03%   56.52%   -0.52%     
==========================================
  Files         350      380      +30     
  Lines       19489    24119    +4630     
==========================================
+ Hits        11116    13633    +2517     
- Misses       7541     9571    +2030     
- Partials      832      915      +83
Impacted Files Coverage Δ
pkg/collector/metadata/agentchecks/payload.go 0% <ø> (ø) ⬆️
pkg/collector/py/datadog_agent.go 49.51% <100%> (+2.34%) ⬆️
pkg/collector/metadata/agentchecks/agentchecks.go 42.85% <100%> (+1.19%) ⬆️
pkg/metadata/checkmetadata/check_metadata.go 100% <100%> (ø)
pkg/util/containers/metrics/common.go 80.95% <0%> (-19.05%) ⬇️
pkg/metadata/host/host.go 62.79% <0%> (-15.86%) ⬇️
pkg/logs/input/file/file_provider.go 79.06% <0%> (-15.38%) ⬇️
pkg/util/docker/event_types.go 85.71% <0%> (-14.29%) ⬇️
pkg/logs/input/file/rotate.go 41.17% <0%> (-12.67%) ⬇️
pkg/logs/input/file/tailer.go 70.63% <0%> (-11.78%) ⬇️
... and 239 more

@ofek
ofek force-pushed the ofek/metadata branch 3 times, most recently from 7c3da93 to c688b10 Compare November 6, 2018 05:35
This was referenced Nov 6, 2018
Closed
Closed
@ofek
ofek force-pushed the ofek/metadata branch 3 times, most recently from a4b2f8f to 061fed3 Compare November 6, 2018 07:14
@ofek ofek removed this from the 6.8.0 milestone Nov 14, 2018
@olivielpeau olivielpeau added this to the Triage milestone Nov 29, 2018
gzussa
gzussa suggested changes Apr 9, 2019
View reviewed changes

@gzussa gzussa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to get this feature in but instead of sending infos to DD, let's add them to the flare cmd.
Also, let's get rid of the metadata name everywhere. What about using infos or details?

@olivielpeau

olivielpeau commented Apr 10, 2019

Copy link
Copy Markdown
Member

just realized this PR existed, so adding a note here: we have an OKR in Q2 about sending some more Agent telemetry, this could part of the effort (we have a stretch key result about sending more info about running agent integrations: version of integration, version of software that's monitored).

We should have a discussion/RFC in Q2 about what the payload should look like before reviewing this PR (having in mind the current backend contraints, and long-term goals)

@ofek

ofek commented Jun 24, 2019

Copy link
Copy Markdown
Contributor Author

Just some info for those coming here:

  1. This will be prioritized in just a few weeks
  2. We're keeping metadata now that we renamed the impetus for that request

@ofek

ofek commented Sep 26, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Updated here: #4158
Ported to RTLoader here: #4234

@ofek ofek closed this Sep 26, 2019
@ofek
ofek deleted the ofek/metadata branch September 26, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@gzussa gzussa gzussa requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

[deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead.. [deprecated] team/integrations do-not-merge/WIP

Projects

None yet

Milestone

Triage

Development

Successfully merging this pull request may close these issues.

4 participants

@ofek @codecov-io @olivielpeau @gzussa
Morty Proxy This is a proxified and sanitized view of the page, visit original site.