Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix safe recursive traversal crashes (#54/#73) - #83

#83
Merged
DamianEdwards merged 5 commits into
mainDamianEdwards/MiniValidation:mainfrom
dedwards/0.10-fix-safe-recursive-traversalDamianEdwards/MiniValidation:dedwards/0.10-fix-safe-recursive-traversalCopy head branch name to clipboard
May 4, 2026
Merged

Fix safe recursive traversal crashes (#54/#73)#83
DamianEdwards merged 5 commits into
mainDamianEdwards/MiniValidation:mainfrom
dedwards/0.10-fix-safe-recursive-traversalDamianEdwards/MiniValidation:dedwards/0.10-fix-safe-recursive-traversalCopy head branch name to clipboard

Conversation

@DamianEdwards

@DamianEdwards DamianEdwards commented May 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

Fixes #54
Fixes #73

Summary

  • Treat delegates, reflection types, and known JSON/dynamic framework payload/configuration types as terminal during recursive validation.
  • Skip terminal runtime values reached through polymorphic/object properties instead of swallowing arbitrary property getter exceptions.
  • Add regression coverage for Func, System.Text.Json.JsonSerializerOptions, and a JToken-like throwing getter.

Testing

  • dotnet restore .\MiniValidation.slnx --verbosity minimal
  • dotnet build .\MiniValidation.slnx --configuration Release --no-restore --verbosity minimal
  • dotnet test .\tests\MiniValidation.UnitTests\MiniValidation.UnitTests.csproj --configuration Release --no-restore --no-build --verbosity minimal

DamianEdwards and others added 3 commits May 3, 2026 20:53
@DamianEdwards
Fix safe recursive traversal for delegates and JSON types
70d14c9 
Treat delegates, reflection types, and known JSON/dynamic framework payload types as terminal during recursive validation so property traversal does not crash on function objects or JSON configuration/payload objects.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@DamianEdwards
Update test targets to supported .NET versions
2d6877c 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@DamianEdwards
Refresh TypeDescriptor cache when attributes change
9ab6340 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
DamianEdwards
DamianEdwards commented May 4, 2026
View reviewed changes
Comment thread tests/MiniValidation.UnitTests/Recursion.cs Outdated
DamianEdwards
DamianEdwards commented May 4, 2026
View reviewed changes
Comment thread tests/MiniValidation.UnitTests/TestTypes.cs Outdated
@DamianEdwards DamianEdwards mentioned this pull request May 4, 2026
Open
DamianEdwards and others added 2 commits May 3, 2026 21:32
@DamianEdwards
Remove obsolete net6 guards from traversal tests
5998de3 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@DamianEdwards
Merge main into safe recursive traversal branch
c99a092 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@DamianEdwards
DamianEdwards merged commit 6653d19 into main May 4, 2026
1 check passed
@DamianEdwards DamianEdwards mentioned this pull request May 4, 2026
Closed
This was referenced May 5, 2026
Merged
Open
Closed
Merged
This was referenced May 13, 2026
Open
Closed
@dependabot dependabot Bot mentioned this pull request May 25, 2026
Closed
This was referenced Jun 1, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support of anonymous functions Safer recursive validation.

1 participant

@DamianEdwards
Morty Proxy This is a proxified and sanitized view of the page, visit original site.