Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

DGEC migration prep#70

Merged
RobLBaker merged 2 commits into
DOI-NPS:mainDOI-NPS/NPSdataverse:mainfrom
RobLBaker:mainRobLBaker/NPSdataverse:mainCopy head branch name to clipboard
Apr 27, 2026
Merged

DGEC migration prep#70
RobLBaker merged 2 commits into
DOI-NPS:mainDOI-NPS/NPSdataverse:mainfrom
RobLBaker:mainRobLBaker/NPSdataverse:mainCopy head branch name to clipboard

Conversation

@RobLBaker

Copy link
Copy Markdown
Member

closes #69

@wright13 could you please provide a code review? Very little has changed except the URLs where the various packages are/will be located.

Please consider:

  • Are there any violations of the DGEC Rules of Behavior such as prohibited content?
  • Are there any cybersecurity concerns?
  • Does the code work as intended (this may require subject matter expertise to address questions such as “are the model results accurate and reasonable”)?

I'd also appreciate feedback on:

  • Is the coding style consistent and easy to understand?
  • Is the code well documented/commented?
  • Does the code complexity or structure facilitate future maintenance and development?

@RobLBaker
RobLBaker requested a review from wright13 April 22, 2026 18:26
@RobLBaker RobLBaker self-assigned this Apr 22, 2026
@RobLBaker RobLBaker added the enhancement New feature or request label Apr 22, 2026

@wright13 wright13 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@RobLBaker
RobLBaker merged commit 258be2c into DOI-NPS:main Apr 27, 2026
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DGEC migration

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.