Rename SpatialSkill to GriddedSkill - #315
#315Merged
ecomodeller merged 24 commits intoDec 11, 2023
Merged
Conversation
Member
|
grid_skill or gridded_skill 🤔? or skill_grid? |
jsmariegaard
reviewed
Dec 8, 2023
| n_min=None, | ||
| **kwargs, | ||
| ): | ||
| warnings.warn("grid_skill is deprecated, use grid_skill instead", FutureWarning) |
Member
There was a problem hiding this comment.
🤔(grid_skill is dead, long live grid_skill)
…hod (for consistency)
Assuming AggregatedSkill will be renamed to SkillSet
jsmariegaard
self-requested a review
December 11, 2023 09:58
jsmariegaard
approved these changes
Dec 11, 2023
jsmariegaard
left a comment
Member
There was a problem hiding this comment.
I am happy with this.
@ecomodeller should we merge?
Member
|
Oops - mypy error - but apart from this I am happy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fieldargument)