Wait for websockets to close on server stop#1171
Open
DavidPetkovsek wants to merge 3 commits into
CrowCpp:masterCrowCpp/Crow:masterfrom
DavidPetkovsek:bug/close-websockets-on-stopDavidPetkovsek/Crow:bug/close-websockets-on-stopCopy head branch name to clipboard
Open
Wait for websockets to close on server stop#1171DavidPetkovsek wants to merge 3 commits intoCrowCpp:masterCrowCpp/Crow:masterfrom DavidPetkovsek:bug/close-websockets-on-stopDavidPetkovsek/Crow:bug/close-websockets-on-stopCopy head branch name to clipboard
DavidPetkovsek wants to merge 3 commits into
CrowCpp:masterCrowCpp/Crow:masterfrom
DavidPetkovsek:bug/close-websockets-on-stopDavidPetkovsek/Crow:bug/close-websockets-on-stopCopy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug is a race between
close_websockets()inapp.hand stopping theio_context/io_serviceobjects that would actually send the close frame.This change makes it so then the close frame for this function uses an alternative call that contains a promise that is used to avoid a race.
If it takes too long (5 seconds) it will proceed anyway and no close frame will be provided and a crow log is added.