Rename all swifty-style boolean configuration properties#99
Rename all swifty-style boolean configuration properties#99liamnichols merged 26 commits intomainCreateAPI/CreateAPI:mainfrom ln/replace-swifty-boolean-optionsCreateAPI/CreateAPI:ln/replace-swifty-boolean-optionsCopy head branch name to clipboard
Conversation
…atchParametersDoubleOptional
|
Hey, @liamnichols. I reviewed the new names and sharing a few thoughts. I don't have any strong feelings about these names though, so don't feel like you need to respond, but please consider updating some of these names.
|
|
Thanks @kean for the feedback!
This is good to know, in that case I think
Ok thanks, I'll take a look at it but will probably leave it for now as I'm still not too sure what it does exactly 😄
Good point, maybe to align with the others
heh yeah I was a little stuck on this. To be honest, I was trying not to use the term I feel like generate is a bit repetitive because these are options for the generator hence going for a term like include instead. "Include the initialisers when generating entities" for example.
Yeah this too could be
In #100 we decided to do like you suggested and replace it with an
Heh yeah. I've actually left this one undocumented in ConfigOptions.md because I want us to revisit it (part of #18 maybe). I think its fine how it is for 0.1 but it will likely change again soon.
I think also |
Background
Property names such as
isDoingFooare out of place in YAML configuration files so for 0.1 we plan to normalise them all.Changes
In this change, I rename the following properties:
isUsingIntegersWithPredefinedCapacityuseIntegersWithPredefinedCapacityisNaiveDateEnableduseNaiveDateisPluralizationEnabledpluralizePropertiesisInliningTypealiasesinlineTypealiasesisGeneratingSwiftyBooleanPropertyNamesuseSwiftyPropertyNamesisGeneratingEnumsgenerateEnumsisAddingDeprecationsannotateDeprecationsisStrippingParentNameInNestedObjectsstripParentNameInNestedObjectsisInliningPropertiesFromReferencedSchemasinlineReferencedSchemasisAddingDefaultValuesdefaultValuesisSortingPropertiesAlphabeticallysortPropertiesAlphabeticallyisGeneratingEncodeWithEncoderalwaysIncludeEncodableImplementationisGeneratingInitWithDecoderalwaysIncludeDecodableImplementationisGeneratingInitializersincludeInitializerisSkippingRedundantProtocolsskipRedundantProtocolsisGeneratingIdentifiableConformanceidentifiableConformanceisGeneratingMutableStructPropertiesmutableStructPropertiesisGeneratingMutableClassPropertiesmutableClassPropertiesisMakingClassesFinalmakeClassesFinalisGeneratingStructsgenerateStructsisRemovingRedundantPathsremoveRedundantPathsisMakingOptionalPatchParametersDoubleOptionalmakeOptionalPatchParametersDoubleOptionalisInliningSimpleQueryParametersinlineSimpleQueryParametersisInliningSimpleRequestsinlineSimpleRequestsisGeneratingResponseHeadersgenerateResponseHeadersAnd I replace the following:
isGeneratingCustomCodingKeysoptimizeCodingKeysI left a few that I will followup on individually:
isAddingOperationIds#92isAdditionalPropertiesOnByDefault? #93isSwiftLintDisabled? #94acronymrelated properties #97commentsconfiguration #98