Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Simplify comments configuration #98

Copy link
Copy link
@liamnichols

Description

@liamnichols
Issue body actions

The comments configuration is currently an object with 5 customisations expressed as Bool and 1 main isEnabled flag.

In my head, we could express this the same way with an enum/option set of values and a single commentFeatures array/set.. Something like the following:

Disable Comments:

commentFeatures: []

Everything:

commentFeatures:
- title
- description
- example
- externalDocumentation
- capitalized

Description (capitalized):

commentFeatures:
- description
- capitalized

In Swift, this would be something like the following:

public enum CommentFeature: String {
    case title, description, example, externalDocumentation, capitalized
}

public var commentFeatures: Set<CommentFeature> = [.title, .description, .example, .externalDocumentation, .capitalized]

Alternatively I'll just deswiftify the boolean properties on the existing object.

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.