Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Improve 'RequiresCSharpLanguageVersionPreviewAnalyzer' - #988

#988
Merged
Sergio0694 merged 2 commits into
mainCommunityToolkit/dotnet:mainfrom
dev/tweak-roslyn-version-analyzerCommunityToolkit/dotnet:dev/tweak-roslyn-version-analyzerCopy head branch name to clipboard
Nov 14, 2024
Merged

Improve 'RequiresCSharpLanguageVersionPreviewAnalyzer'#988
Sergio0694 merged 2 commits into
mainCommunityToolkit/dotnet:mainfrom
dev/tweak-roslyn-version-analyzerCommunityToolkit/dotnet:dev/tweak-roslyn-version-analyzerCopy head branch name to clipboard

Conversation

@Sergio0694

Copy link
Copy Markdown
Member

This PR improves RequiresCSharpLanguageVersionPreviewAnalyzer to skip warning on non-partial properties.

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added improvements ✨ Improvements to an existing functionality mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit analyzer 👓 A new analyzer being implemented or updated labels Nov 14, 2024
@Sergio0694
Sergio0694 merged commit 5009433 into main Nov 14, 2024
@Sergio0694
Sergio0694 deleted the dev/tweak-roslyn-version-analyzer branch November 14, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

analyzer 👓 A new analyzer being implemented or updated improvements ✨ Improvements to an existing functionality mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.