Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Update SDK package checks for .NET 9 SDK - #952

#952
Merged
Sergio0694 merged 1 commit into
mainCommunityToolkit/dotnet:mainfrom
dev/update-framework-reference-checksCommunityToolkit/dotnet:dev/update-framework-reference-checksCopy head branch name to clipboard
Sep 18, 2024
Merged

Update SDK package checks for .NET 9 SDK#952
Sergio0694 merged 1 commit into
mainCommunityToolkit/dotnet:mainfrom
dev/update-framework-reference-checksCommunityToolkit/dotnet:dev/update-framework-reference-checksCopy head branch name to clipboard

Conversation

@Sergio0694

Copy link
Copy Markdown
Member

This PR improves the Windows SDK package version validation logic added in #942 and makes them work correctly when using the .NET 9 SDK (starting from .NET 9 RC2, or a latest nightly, which include the UWP support for .NET 9 changes).

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit bugfix 🔧 PRs fixing a discovered bug labels Sep 15, 2024
@Sergio0694
Sergio0694 merged commit 9accd8a into main Sep 18, 2024
@Sergio0694
Sergio0694 deleted the dev/update-framework-reference-checks branch September 18, 2024 11:31
Sergio0694 added a commit that referenced this pull request Sep 18, 2024
…ference-checks

Update SDK package checks for .NET 9 SDK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix 🔧 PRs fixing a discovered bug mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.