Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix generation for OnPropertyChanging for [NotifyPropertyChangedFor] - #722

#722
Merged
Sergio0694 merged 3 commits into
mainCommunityToolkit/dotnet:mainfrom
dev/notify-for-changingCommunityToolkit/dotnet:dev/notify-for-changingCopy head branch name to clipboard
Oct 24, 2023
Merged

Fix generation for OnPropertyChanging for [NotifyPropertyChangedFor]#722
Sergio0694 merged 3 commits into
mainCommunityToolkit/dotnet:mainfrom
dev/notify-for-changingCommunityToolkit/dotnet:dev/notify-for-changingCopy head branch name to clipboard

Conversation

@Sergio0694

Copy link
Copy Markdown
Member

Closes #711

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit analyzer 👓 A new analyzer being implemented or updated labels Jun 21, 2023
@Sergio0694

Copy link
Copy Markdown
Member Author

This is ready, but re-targeting this to 9.0 since it's relatively higher risk (and semantically a breaking change).

@Sergio0694 Sergio0694 added the introduce breaking changes 💥 This change would be a breaking change label Jun 21, 2023
@Sergio0694
Sergio0694 force-pushed the dev/notify-for-changing branch from 62cf0f6 to 8857555 Compare October 24, 2023 19:45
@Sergio0694
Sergio0694 merged commit 7b53ae2 into main Oct 24, 2023
@Sergio0694
Sergio0694 deleted the dev/notify-for-changing branch October 24, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

analyzer 👓 A new analyzer being implemented or updated introduce breaking changes 💥 This change would be a breaking change mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

OnPropertyChanging not called for generated property

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.