Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Support more partial property modifiers, ban pointer types - #1015

#1015
Merged
Sergio0694 merged 4 commits into
mainCommunityToolkit/dotnet:mainfrom
dev/better-modifiers-supportCommunityToolkit/dotnet:dev/better-modifiers-supportCopy head branch name to clipboard
Dec 5, 2024
Merged

Support more partial property modifiers, ban pointer types#1015
Sergio0694 merged 4 commits into
mainCommunityToolkit/dotnet:mainfrom
dev/better-modifiers-supportCommunityToolkit/dotnet:dev/better-modifiers-supportCopy head branch name to clipboard

Conversation

@Sergio0694

Copy link
Copy Markdown
Member

Closes #1013

This PR includes a few changes to the MVVM Toolkit:

  • Support forwarding more modifiers on partial properties (new, virtual, sealed, override)
  • Add a new analyzer to error on pointer and function pointer types

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added improvements ✨ Improvements to an existing functionality mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit analyzer 👓 A new analyzer being implemented or updated labels Dec 5, 2024
@Sergio0694 Sergio0694 changed the title Dev/better modifiers support Support more partial property modifiers, ban pointer types Dec 5, 2024
@Sergio0694
Sergio0694 merged commit 2aad03c into main Dec 5, 2024
@Sergio0694
Sergio0694 deleted the dev/better-modifiers-support branch December 5, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

analyzer 👓 A new analyzer being implemented or updated improvements ✨ Improvements to an existing functionality mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ObservableProperty source generator does not output new keyword for partial auto-properties

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.