Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Reinstate assembly versioning - #2837

#2837
Merged
TheCodeTraveler merged 1 commit into
mainCommunityToolkit/Maui:mainfrom
jfversluis-patch-1CommunityToolkit/Maui:jfversluis-patch-1Copy head branch name to clipboard
Jul 29, 2025
Merged

Reinstate assembly versioning#2837
TheCodeTraveler merged 1 commit into
mainCommunityToolkit/Maui:mainfrom
jfversluis-patch-1CommunityToolkit/Maui:jfversluis-patch-1Copy head branch name to clipboard

Conversation

@jfversluis

Copy link
Copy Markdown
Member

Reinstates the assembly versioning that was implemented with #2328 but got lost in the transition from Azure Pipelines to GitHub Actions

Fixes #2836

@jfversluis
jfversluis marked this pull request as ready for review July 29, 2025 20:02
Copilot AI review requested due to automatic review settings July 29, 2025 20:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reinstates assembly versioning functionality that was previously lost during the migration from Azure Pipelines to GitHub Actions. The changes ensure that each package component gets the correct version assignment for both PackageVersion and Version properties during build and pack operations.

  • Corrects version property assignments for Camera, MediaElement, and Maps packages during build steps
  • Adds missing Version property assignments for all packages during pack operations
  • Ensures consistent versioning across all CommunityToolkit.Maui components

@TheCodeTraveler
TheCodeTraveler enabled auto-merge (squash) July 29, 2025 20:24
@TheCodeTraveler
TheCodeTraveler merged commit d625a24 into main Jul 29, 2025
17 of 18 checks passed
@TheCodeTraveler
TheCodeTraveler deleted the jfversluis-patch-1 branch July 29, 2025 20:29
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Assemblies have lower version (and fileversion) than 11.2 causing problems with the Windows Installer

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.