Migrate internal tests to the canonical v5 Support layout - #6943
#6943Merged
TavoNiievez merged 3 commits intoJun 24, 2026
Codeception:mainCodeception/Codeception:mainfrom
TavoNiievez:tests/v5-layout-migrationTavoNiievez/Codeception:tests/v5-layout-migrationCopy head branch name to clipboard
Merged
Migrate internal tests to the canonical v5 Support layout#6943TavoNiievez merged 3 commits intoCodeception:mainCodeception/Codeception:mainfrom TavoNiievez:tests/v5-layout-migrationTavoNiievez/Codeception:tests/v5-layout-migrationCopy head branch name to clipboard
TavoNiievez merged 3 commits into
Codeception:mainCodeception/Codeception:mainfrom
TavoNiievez:tests/v5-layout-migrationTavoNiievez/Codeception:tests/v5-layout-migrationCopy head branch name to clipboard
Conversation
`generate:cest` produces classes that are `final` and declare `strict_types=1`; these five Cests predate that template. Add the missing `declare(strict_types=1)` (5 files) and `final` (4 files) so the internal suite matches what Codeception itself generates. No behavioral change.
`settings.suite_class: \PHPUnit_Framework_TestSuite` referenced a class removed in PHPUnit 6; nothing in src/ reads `suite_class`, so it was dead config. `tests/cli.suite.yml` used the legacy `steps:` key, which is silently ignored — the honored v5 key is `step_decorators:`. The value (ConditionalAssertion) was already applied via the default, so this is behavior-neutral cleanup.
TavoNiievez
force-pushed
the
tests/v5-layout-migration
branch
from
June 24, 2026 19:42
ad451dd to
6646e50
Compare
Adopt namespace: Tests + support_namespace: Support; move tests/support -> tests/Support (PSR-4 Tests\Support, added to composer autoload-dev); rename actors CliGuy/CodeGuy/CoverGuy -> CliTester/CodeTester/CoverTester; move helpers under Tests\Support\Helper and reference them by FQCN in the suite configs. EmulateModuleHelper stays in namespace Codeception\Module (classmap-loaded) because several core unit tests use it as the sample for short-name -> Codeception\Module resolution. Test references and generated-output assertions updated to match; fixtures under tests/data/ are left on the legacy layout and migrated separately.
TavoNiievez
force-pushed
the
tests/v5-layout-migration
branch
from
June 24, 2026 19:52
6646e50 to
a9ef771
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the framework's own self-tests (
tests/) in line with the canonical Codeception v5 layout produced bycodecept bootstrapand the generators. Structure/config only — no test logic rewritten.Changes
suite_classsetting;steps:→step_decorators:.codeception.ymlgainsnamespace: Tests+support_namespace: Support;tests/support→tests/Support(PSR-4Tests\Supportincomposer.json).*Guy→*Tester; helpers moved toTests\Support\Helperand referenced by FQCN in suite configs.declare(strict_types=1)+final).Deliberately preserved
tests/data/**(incl.claypit) is left as-is. These are intentionally multi-convention fixtures (global actors, short-nameCodeception\Moduleresolution, namespaced helpers, legacysteps:) — migrating them would delete the coverage they provide.Verification
cli,unit,coveragegreen on case-sensitive Linux — identical to the pre-change baseline (the one pre-existing, TTY-width-dependentDataProviderFailuresAndExceptionsCestfailure persists and is unrelated).