Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 72ea677

Browse filesBrowse files
authored
Do not expect the register_argc_argv ini setting in cli for php >= 8.5 (#6921)
register_argc_argv is ignored as of PHP 8.5 if the cli SAPI is used.
1 parent 036183e commit 72ea677
Copy full SHA for 72ea677

2 files changed

+3-28Lines changed: 3 additions & 28 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎.github/workflows/build.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/build.yml
+2-27Lines changed: 2 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,6 @@ permissions:
1818

1919
env:
2020
PHP_INI_VALUES: memory_limit=-1,date.timezone=UTC
21-
# register_argc_argv seems to be off by default in PHP 8.5
22-
# see https://github.com/php/php-src/issues/20279
23-
# enable it because codeception relies on it.
24-
PHP_INI_VALUES_PHP_85: memory_limit=-1,date.timezone=UTC,register_argc_argv=1
2521
COMPOSER_ROOT_VERSION: 5.0.99
2622
SYMFONY_DEPRECATIONS_HELPER: weak
2723

@@ -76,26 +72,15 @@ jobs:
7672
- name: Checkout
7773
uses: actions/checkout@v6
7874

79-
- name: Install PHP != 8.5 & Composer
75+
- name: Install PHP & Composer
8076
uses: shivammathur/setup-php@v2
81-
if: ${{ matrix.php != '8.5' }}
8277
with:
8378
php-version: ${{ matrix.php }}
8479
extensions: ${{ env.extensions }}
8580
ini-values: ${{ env.PHP_INI_VALUES }}
8681
coverage: xdebug
8782
tools: composer:v2
8883

89-
- name: Install PHP 8.5 & Composer
90-
uses: shivammathur/setup-php@v2
91-
if: ${{ matrix.php == '8.5' }}
92-
with:
93-
php-version: ${{ matrix.php }}
94-
extensions: ${{ env.extensions }}
95-
ini-values: ${{ env.PHP_INI_VALUES_PHP_85 }}
96-
coverage: xdebug
97-
tools: composer:v2
98-
9984
- name: Determine composer cache directory
10085
run: echo "COMPOSER_CACHE_DIR=$(composer config cache-dir)" >> $GITHUB_ENV
10186

@@ -175,24 +160,14 @@ jobs:
175160
- name: Checkout
176161
uses: actions/checkout@v6
177162

178-
- name: Install PHP != 8.5 & Composer
163+
- name: Install PHP & Composer
179164
uses: shivammathur/setup-php@v2
180-
if: ${{ matrix.php != '8.5' }}
181165
with:
182166
php-version: ${{ matrix.php }}
183167
extensions: ${{ env.extensions }}
184168
ini-values: ${{ env.PHP_INI_VALUES }}
185169
tools: composer:v2
186170

187-
- name: Install PHP 8.5 & Composer
188-
uses: shivammathur/setup-php@v2
189-
if: ${{ matrix.php == '8.5' }}
190-
with:
191-
php-version: ${{ matrix.php }}
192-
extensions: ${{ env.extensions }}
193-
ini-values: ${{ env.PHP_INI_VALUES_PHP_85 }}
194-
tools: composer:v2
195-
196171
- name: Determine composer cache directory
197172
run: |
198173
echo "COMPOSER_CACHE_DIR=~\\AppData\\Local\\Composer" >> $GITHUB_ENV
Collapse file

‎src/Codeception/Application.php‎

Copy file name to clipboardExpand all lines: src/Codeception/Application.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ public function run(?InputInterface $input = null, ?OutputInterface $output = nu
100100
$input = $this->getCoreArguments();
101101
}
102102

103-
if (!ini_get('register_argc_argv')) {
103+
if ((PHP_VERSION_ID < 80500 || 'cli' !== php_sapi_name()) && !ini_get('register_argc_argv')) {
104104
throw new ConfigurationException('register_argc_argv must be set to On for running Codeception');
105105
}
106106

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.