Fix internal projection selections leaking into the response - #9978
#9978Merged
Merged
Fix internal projection selections leaking into the response#9978
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a correctness issue where execution-engine-internal projection selections (for example _combinedSelectionSet, __projection_alias_N) could leak into the client-facing response via null-propagation and/or surfaced errors. It ensures internal selections are treated as fully internal across their subtrees and that their errors and nulls are contained.
Changes:
- Propagate “internal” status down the selection subtree during operation compilation so nested selections under an internal selection are also internal.
- Treat internal result elements as nullable to prevent null-propagation from internal selections affecting the client response, and suppress reporting errors for internal selections.
- Add regression tests for projection + authorization interactions and update related snapshots; add required test project reference.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/HotChocolate/Data/test/Data.Tests/ProjectionAuthorizationTests.cs | Adds regression tests ensuring internal projection selections neither surface data nor errors unless explicitly selected by the client. |
| src/HotChocolate/Data/test/Data.Tests/HotChocolate.Data.Tests.csproj | Adds a project reference needed for authorization types used in the new tests. |
| src/HotChocolate/Core/test/Execution.Tests/Processing/snapshots/OperationCompilerTests.Field_Based_Optimizers.snap | Updates snapshot to reflect internal propagation changes in compiled operations. |
| src/HotChocolate/Core/src/Types/Text/Json/ResultElement.cs | Treats internal selections as nullable to contain null/error propagation. |
| src/HotChocolate/Core/src/Types/Execution/Processing/OperationCompiler.cs | Ensures “internal” status is inherited by nested selections during compilation. |
| src/HotChocolate/Core/src/Types/Execution/Processing/MiddlewareContext.Global.cs | Suppresses client-facing error reporting for internal selections to prevent leakage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Code Coverage OverviewLanguages: C# C# / code-coverage/dotnetThe overall coverage in the Show a code coverage summary of the most impacted files.
Code Coverage is in Public Preview. Learn more and provide us with your feedback. |
This was referenced Jun 26, 2026
This was referenced Jul 5, 2026
This was referenced Jul 13, 2026
This was referenced Jul 14, 2026
This was referenced Jul 23, 2026
chore(deps): Bump HotChocolate.Subscriptions.InMemory from 15.1.14 to 16.5.1
Kuestenlogik/Bowire#506
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9939