[Nitro CLI] Force non-interactive mode when output format is set - #9844
#9844Merged
tobias-tengler merged 1 commit intoJun 4, 2026
mainChilliCream/graphql-platform:mainfrom
tte/fix-output-json-for-interactive-terminalsChilliCream/graphql-platform:tte/fix-output-json-for-interactive-terminalsCopy head branch name to clipboard
Merged
[Nitro CLI] Force non-interactive mode when output format is set#9844tobias-tengler merged 1 commit intomainChilliCream/graphql-platform:mainfrom tte/fix-output-json-for-interactive-terminalsChilliCream/graphql-platform:tte/fix-output-json-for-interactive-terminalsCopy head branch name to clipboard
tobias-tengler merged 1 commit into
mainChilliCream/graphql-platform:mainfrom
tte/fix-output-json-for-interactive-terminalsChilliCream/graphql-platform:tte/fix-output-json-for-interactive-terminalsCopy head branch name to clipboard
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures Nitro CLI commands behave non-interactively whenever an output format (currently --output json) is selected, even when running in an interactive TTY. This aligns CLI behavior with the option’s intent (“enables non-interactive mode”) and prevents prompts/progress UI from appearing in structured output scenarios.
Changes:
- Update
NitroConsole.IsInteractiveto returnfalsewhenever output is not human-readable (i.e., an output format is set). - Adjust the command test harness to simulate an interactive terminal while using
--output json, ensuring coverage of the intended behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Nitro/CommandLine/test/CommandLine.Tests/Commands/CommandTestBase.cs | Updates JSON-output test setup to simulate an interactive TTY while asserting --output json still forces non-interactive behavior. |
| src/Nitro/CommandLine/src/CommandLine/Services/Console/NitroConsole.cs | Makes interactivity conditional on human-readable output, so selecting an output format disables interactive mode. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Jun 5, 2026
This was referenced Jun 16, 2026
This was referenced Jun 26, 2026
This was referenced Jun 28, 2026
This was referenced Jul 5, 2026
This was referenced Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.