Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add implicit conversion to PageConnection from Page - #9806

#9806
Merged
michaelstaib merged 3 commits into
mainChilliCream/graphql-platform:mainfrom
mst/page-connection-implicitChilliCream/graphql-platform:mst/page-connection-implicitCopy head branch name to clipboard
May 31, 2026
Merged

Add implicit conversion to PageConnection from Page#9806
michaelstaib merged 3 commits into
mainChilliCream/graphql-platform:mainfrom
mst/page-connection-implicitChilliCream/graphql-platform:mst/page-connection-implicitCopy head branch name to clipboard

Conversation

@michaelstaib

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings May 31, 2026 21:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an implicit conversion operator from GreenDonut.Data.Page<TNode> to HotChocolate.Types.Pagination.PageConnection<TNode>, removing the need for callers to explicitly wrap a Page<TNode> when returning it where a PageConnection<TNode> is expected. This aligns with documentation examples that already return Page<T> from resolvers declared as Task<PageConnection<T>>.

Changes:

  • Add implicit operator PageConnection<TNode>(Page<TNode> page) delegating to the existing constructor.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@michaelstaib
michaelstaib merged commit 0d144b7 into main May 31, 2026
144 checks passed
@michaelstaib
michaelstaib deleted the mst/page-connection-implicit branch May 31, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.