[Fusion] Do not apply @shareable to subscription root fields - #9751
#9751Merged
tobias-tengler merged 1 commit intoMay 20, 2026
mainChilliCream/graphql-platform:mainfrom
tte/do-not-apply-shareable-to-subscription-typeChilliCream/graphql-platform:tte/do-not-apply-shareable-to-subscription-typeCopy head branch name to clipboard
Merged
[Fusion] Do not apply @shareable to subscription root fields#9751tobias-tengler merged 1 commit intomainChilliCream/graphql-platform:mainfrom tte/do-not-apply-shareable-to-subscription-typeChilliCream/graphql-platform:tte/do-not-apply-shareable-to-subscription-typeCopy head branch name to clipboard
tobias-tengler merged 1 commit into
mainChilliCream/graphql-platform:mainfrom
tte/do-not-apply-shareable-to-subscription-typeChilliCream/graphql-platform:tte/do-not-apply-shareable-to-subscription-typeCopy head branch name to clipboard
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Fusion v1 compatibility preprocessing so @shareable is not automatically applied to fields on the subscription root type, and adds a regression test to lock in the behavior.
Changes:
- Skip the subscription root type when applying inferred
@shareabledirectives during Fusion v1 compatibility preprocessing. - Add a unit test verifying that subscription root fields do not receive
@shareableeven when present in multiple source schemas.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/HotChocolate/Fusion/src/Fusion.Composition/SourceSchemaPreprocessor.cs | Excludes schema.SubscriptionType from inferred @shareable application in v1 compatibility mode. |
| src/HotChocolate/Fusion/test/Fusion.Composition.Tests/SourceSchemaPreprocessorTests.cs | Adds regression coverage ensuring subscription root fields are not marked @shareable. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tobias-tengler
deleted the
tte/do-not-apply-shareable-to-subscription-type
branch
May 20, 2026 12:30
This was referenced May 20, 2026
This was referenced May 30, 2026
This was referenced Jun 8, 2026
This was referenced Jun 16, 2026
This was referenced Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.