Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts namespaces for MCP adapter extension methods to reduce the need for extra using directives and to align entry points with commonly imported namespaces (e.g., Microsoft.Extensions.DependencyInjection, HotChocolate, HotChocolate.Types).
Changes:
- Move MCP extension method containers into more commonly used namespaces (DI,
HotChocolate, andHotChocolate.Types). - Update docs/tests to remove now-unnecessary
using HotChocolate.Adapters.Mcp.Extensions;. - Rename the object-field descriptor extension container to avoid a name collision in
HotChocolate.Types.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| website/src/docs/hotchocolate/v16/guides/mcp-adapter.md | Updates docs snippet to reflect the new extension method namespace. |
| src/HotChocolate/Adapters/test/Adapters.Mcp.Tests/OperationToolFactoryTests.cs | Removes now-unnecessary using for MCP extensions. |
| src/HotChocolate/Adapters/src/Fusion.Adapters.Mcp/Extensions/FusionGatewayBuilderExtensions.cs | Moves Fusion MCP gateway extensions into Microsoft.Extensions.DependencyInjection. |
| src/HotChocolate/Adapters/src/Adapters.Mcp/Extensions/SchemaBuilderExtensions.cs | Moves schema builder extension into HotChocolate namespace. |
| src/HotChocolate/Adapters/src/Adapters.Mcp/Extensions/ObjectFieldDescriptorExtensions.cs | Moves field-descriptor extension into HotChocolate.Types and renames the class to avoid collisions. |
| src/HotChocolate/Adapters/src/Adapters.Mcp.Core/Extensions/ServiceCollectionExtensions.cs | Removes an unused using. |
Comments suppressed due to low confidence (1)
src/HotChocolate/Adapters/src/Adapters.Mcp/Extensions/SchemaBuilderExtensions.cs:8
- The new namespace change makes this type
HotChocolate.SchemaBuilderExtensions, which already exists in the core library (e.g.src/HotChocolate/Core/src/Types/Extensions/SchemaBuilderExtensions.Types.cs:11). Having two public types with the same fully-qualified name across referenced assemblies will cause ambiguous type resolution for consumers that referenceSchemaBuilderExtensionsdirectly (e.g.SchemaBuilderExtensions.AddQueryType(...)). Consider renaming this class (e.g.McpSchemaBuilderExtensions) while keeping theHotChocolatenamespace, or moving it to a non-conflicting namespace.
// ReSharper disable once CheckNamespace
namespace HotChocolate;
public static class SchemaBuilderExtensions
{
public static ISchemaBuilder AddMcp(this ISchemaBuilder builder)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced May 13, 2026
Closed
This was referenced May 21, 2026
This was referenced May 25, 2026
This was referenced Jun 4, 2026
This was referenced Jun 16, 2026
This was referenced Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.