Remove implicit save changes in mocha ef core middleware - #9501
#9501Merged
PascalSenn merged 2 commits intoApr 2, 2026
mainChilliCream/graphql-platform:mainfrom
pse/fix-mediator-transaction-middlewareChilliCream/graphql-platform:pse/fix-mediator-transaction-middlewareCopy head branch name to clipboard
Merged
Remove implicit save changes in mocha ef core middleware#9501PascalSenn merged 2 commits intomainChilliCream/graphql-platform:mainfrom pse/fix-mediator-transaction-middlewareChilliCream/graphql-platform:pse/fix-mediator-transaction-middlewareCopy head branch name to clipboard
PascalSenn merged 2 commits into
mainChilliCream/graphql-platform:mainfrom
pse/fix-mediator-transaction-middlewareChilliCream/graphql-platform:pse/fix-mediator-transaction-middlewareCopy head branch name to clipboard
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the implicit DbContext.SaveChangesAsync call from Mocha’s EF Core transaction middleware and updates the documentation to reflect that command handlers must persist changes explicitly.
Changes:
- Removed automatic
SaveChangesAsyncinvocation fromEntityFrameworkTransactionMiddlewarebefore committing. - Updated the middleware XML docs to clarify that handlers must call
SaveChangesAsync. - Updated the mediator pipeline documentation and EF transaction section to describe the new responsibility split (handlers save; middleware manages transaction lifecycle).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
website/src/docs/mocha/v1/mediator/pipeline-and-middleware.md |
Updates the transaction middleware examples/description to remove implicit saving and clarify handler responsibilities. |
src/Mocha/src/Mocha.EntityFrameworkCore/EntityFrameworkTransactionMiddleware.cs |
Removes implicit SaveChangesAsync calls and updates XML docs accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PascalSenn
commented
Apr 2, 2026
This was referenced May 1, 2026
Open
This was referenced May 9, 2026
This was referenced May 16, 2026
This was referenced May 18, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.