Fix #8714: @stream fails when list contains fewer items than initialCount - #8715
#8715Merged
michaelstaib merged 2 commits intoSep 17, 2025
ChilliCream:mainChilliCream/graphql-platform:mainfrom
MikeBarker-MSFT:mainMikeBarker-MSFT/graphql-platform-stream-fix:mainCopy head branch name to clipboard
Merged
Fix #8714: @stream fails when list contains fewer items than initialCount#8715michaelstaib merged 2 commits intoChilliCream:mainChilliCream/graphql-platform:mainfrom MikeBarker-MSFT:mainMikeBarker-MSFT/graphql-platform-stream-fix:mainCopy head branch name to clipboard
michaelstaib merged 2 commits into
ChilliCream:mainChilliCream/graphql-platform:mainfrom
MikeBarker-MSFT:mainMikeBarker-MSFT/graphql-platform-stream-fix:mainCopy head branch name to clipboard
Conversation
… than initialCount.
|
|
Member
|
@MikeBarker-MSFT I will merge and cherry pick this one on 15, but be advised that we will implement the new spec draft for 16 which will completely replace how defer and stream work. |
michaelstaib
self-requested a review
September 17, 2025 08:56
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8715 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
michaelstaib
pushed a commit
that referenced
this pull request
Sep 17, 2025
Contributor
Author
|
Thank you @michaelstaib 👍 |
Member
|
@MikeBarker-MSFT your change is now integrated into this preview build: https://github.com/ChilliCream/graphql-platform/releases/tag/15.1.11-p.3 We can do a release next week. |
This was referenced May 13, 2026
Closed
This was referenced May 21, 2026
This was referenced May 25, 2026
This was referenced Jun 4, 2026
This was referenced Jun 16, 2026
This was referenced Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test the return value from
enumerator.MoveNextAsync(), and only add items to the list if the value is valid.Closes #8714