Merged
fix: use qlogging in eventsub lib (through a hoop)#6161
Conversation
|
Previous was comment made in error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a logging proxy to the EventSub lib
It gives the session a warn and debug function it can use to log things, and we can decide how things are logged.
I made a mini qLogging proxy for it, which just forwards the data to categorized Qt logging.
On <Qt6.5 no logging will take place since they don't support qDebug << std::string_view
It's not the most optimized way of logging things but I think it's ok.