add support for ILIKE search feature#509
Open
jbennett wants to merge 4 commits into
Casecommons:masterCasecommons/pg_search:masterfrom
jbennett:features/ilike-searchjbennett/pg_search:features/ilike-searchCopy head branch name to clipboard
Open
add support for ILIKE search feature#509jbennett wants to merge 4 commits intoCasecommons:masterCasecommons/pg_search:masterfrom jbennett:features/ilike-searchjbennett/pg_search:features/ilike-searchCopy head branch name to clipboard
jbennett wants to merge 4 commits into
Casecommons:masterCasecommons/pg_search:masterfrom
jbennett:features/ilike-searchjbennett/pg_search:features/ilike-searchCopy head branch name to clipboard
Conversation
jbennett
marked this pull request as ready for review
March 24, 2023 17:52
|
👏🏼 |
mohamadzoh
approved these changes
Aug 21, 2023
skuo-gh
reviewed
Sep 29, 2023
|
@jbennett thanks for the work, I'd really like to see this getting merged :) any chance? |
jbennett
force-pushed
the
features/ilike-search
branch
from
August 24, 2024 09:41
9425568 to
90575a8
Compare
|
Would love to see this merged :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an additional feature to support doing an ILIKE search to find substrings in within the document. I see a bunch of open issues this would help resolve (#3, #356, #324 etc).
If this strategy looks sane to you I can finish it off (update README) but wanted to do a sanity check first.