Mostly cleanup#59
Open
JuhaManninen wants to merge 14 commits into
Open
Mostly cleanup#59JuhaManninen wants to merge 14 commits into
JuhaManninen wants to merge 14 commits into
Conversation
…tential problems.
…s. Fix visibility.
…ion control. Only sources are needed.
…w work for default target everywhere.
… There are no circular dependencies.
|
Linked to issue #58 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My commits clean up the sources and the whole repository.
Reducing compiler messages about unused variables let's you see real problems more easily. There were real problems like uninitialized variables.
I removed all compiled binary files. They should not be under revision control.
I also removed whole unused Orpheus and OSspecific.
There is one commit where I tried to fix potential memory issues:
Some destructors missed "override". Destructor for TBase was redefined as "virtual". The compiler skipped calling it which can be considered a compiler bug. Changing it to "override" triggered a crash in unrelated GUI component code. There are indeed some serious memory management issues. My patch obviously does not change it to "override". The app is as usable as earlier.
Instead of container classes the code uses dynamic arrays and calls SetLength().
Usually FPC debug flags reveal such memory bugs but not now. :(
I added some warnings. Please take a look.